Merge lp:~fboucault/ubuntu-ui-extras/crossbuild_fixes into lp:ubuntu-ui-extras

Proposed by Florian Boucault
Status: Merged
Approved by: Florian Boucault
Approved revision: 106
Merged at revision: 107
Proposed branch: lp:~fboucault/ubuntu-ui-extras/crossbuild_fixes
Merge into: lp:ubuntu-ui-extras
Diff against target: 58 lines (+4/-22)
3 files modified
debian/control (+1/-2)
modules/Ubuntu/Components/Extras/CMakeLists.txt (+1/-10)
modules/Ubuntu/Components/Extras/plugin/CMakeLists.txt (+2/-10)
To merge this branch: bzr merge lp:~fboucault/ubuntu-ui-extras/crossbuild_fixes
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
PS Jenkins bot continuous-integration Pending
Ubuntu Phablet Team Pending
Review via email: mp+299272@code.launchpad.net

Commit message

Fixes for crossbuilding.

Description of the change

Fixes for crossbuilding.

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:106
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-ui-extras-ci/6/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/852/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/852
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/773
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/773
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/773
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/775
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/775/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/775
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/775/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/775
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/775/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/775/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/775/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/775/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/775
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/775/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/775
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/775/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/775
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/775/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-ui-extras-ci/6/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-12-21 13:56:33 +0000
3+++ debian/control 2016-07-06 08:37:11 +0000
4@@ -6,9 +6,8 @@
5 debhelper (>= 9),
6 gettext,
7 pkg-config,
8- python,
9+ python:any,
10 qt5-default,
11- qt5-qmake,
12 qtbase5-dev,
13 qtdeclarative5-dev,
14 qtdeclarative5-qtquick2-plugin,
15
16=== modified file 'modules/Ubuntu/Components/Extras/CMakeLists.txt'
17--- modules/Ubuntu/Components/Extras/CMakeLists.txt 2014-12-09 11:14:16 +0000
18+++ modules/Ubuntu/Components/Extras/CMakeLists.txt 2016-07-06 08:37:11 +0000
19@@ -1,15 +1,6 @@
20 file(GLOB QML_FILES *.qml qmldir)
21
22-# Qt5's cmake does not export QT_IMPORTS_DIR, lets query qmake on our own for now
23-get_target_property(QMAKE_EXECUTABLE Qt5::qmake LOCATION)
24-function(QUERY_QMAKE VAR RESULT)
25- exec_program(${QMAKE_EXECUTABLE} ARGS "-query ${VAR}" RETURN_VALUE return_code OUTPUT_VARIABLE output )
26- if(NOT return_code)
27- file(TO_CMAKE_PATH "${output}" output)
28- set(${RESULT} ${output} PARENT_SCOPE)
29- endif(NOT return_code)
30-endfunction(QUERY_QMAKE)
31-query_qmake(QT_INSTALL_QML QT_IMPORTS_DIR)
32+set(QT_IMPORTS_DIR "${CMAKE_INSTALL_LIBDIR}/qt5/qml")
33
34 set(PLUGIN_DIR ${QT_IMPORTS_DIR}/Ubuntu/Components/Extras)
35 install(FILES ${QML_FILES} DESTINATION ${PLUGIN_DIR})
36
37=== modified file 'modules/Ubuntu/Components/Extras/plugin/CMakeLists.txt'
38--- modules/Ubuntu/Components/Extras/plugin/CMakeLists.txt 2014-12-09 10:57:19 +0000
39+++ modules/Ubuntu/Components/Extras/plugin/CMakeLists.txt 2016-07-06 08:37:11 +0000
40@@ -30,16 +30,8 @@
41 ${EXIV2_LIBRARIES}
42 )
43
44-# Qt5's cmake does not export QT_IMPORTS_DIR, lets query qmake on our own for now
45-get_target_property(QMAKE_EXECUTABLE Qt5::qmake LOCATION)
46-function(QUERY_QMAKE VAR RESULT)
47- exec_program(${QMAKE_EXECUTABLE} ARGS "-query ${VAR}" RETURN_VALUE return_code OUTPUT_VARIABLE output )
48- if(NOT return_code)
49- file(TO_CMAKE_PATH "${output}" output)
50- set(${RESULT} ${output} PARENT_SCOPE)
51- endif(NOT return_code)
52-endfunction(QUERY_QMAKE)
53-query_qmake(QT_INSTALL_QML QT_IMPORTS_DIR)
54+
55+set(QT_IMPORTS_DIR "${CMAKE_INSTALL_LIBDIR}/qt5/qml")
56
57 set(PLUGIN_DIR ${QT_IMPORTS_DIR}/Ubuntu/Components/Extras)
58 install(TARGETS ubuntu-ui-extras-plugin DESTINATION ${PLUGIN_DIR})

Subscribers

People subscribed via source and target branches