Merge lp:~fboucault/ubuntu-terminal-app/release_0417 into lp:ubuntu-terminal-app

Proposed by Florian Boucault
Status: Merged
Approved by: Florian Boucault
Approved revision: 372
Merged at revision: 359
Proposed branch: lp:~fboucault/ubuntu-terminal-app/release_0417
Merge into: lp:ubuntu-terminal-app
Diff against target: 103 lines (+14/-8)
6 files modified
debian/control (+3/-1)
debian/rules (+1/-1)
src/app/qml/Settings/SettingsWindow.qml (+1/-1)
src/app/qml/TerminalPage.qml (+7/-1)
src/app/qml/helpers.js (+1/-1)
src/plugin/qmltermwidget/lib/TerminalDisplay.cpp (+1/-3)
To merge this branch: bzr merge lp:~fboucault/ubuntu-terminal-app/release_0417
Reviewer Review Type Date Requested Status
Ubuntu Terminal Developers Pending
Review via email: mp+322010@code.launchpad.net

Commit message

Ubuntu Terminal Release (FFe bug #1680114): Introduced desktop style tabs when enough space is available, New visual design for overlaid button and keyboard bar, New application settings dialog, Contextual menu: new cleaner design, Multi-window support, Support for transparent background, Introduced snap packaging

Description of the change

Ubuntu Terminal Release (FFe bug #1680114): Introduced desktop style tabs when enough space is available, New visual design for overlaid button and keyboard bar, New application settings dialog, Contextual menu: new cleaner design, Multi-window support, Support for transparent background, Introduced snap packaging

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2017-03-10 15:18:06 +0000
3+++ debian/control 2017-04-05 14:42:17 +0000
4@@ -14,7 +14,8 @@
5 xvfb,
6 qml-module-qtquick2,
7 qml-module-qttest,
8- qml-module-ubuntu-components
9+ qml-module-ubuntu-components,
10+ qtdeclarative5-gsettings1.0
11 Standards-Version: 3.9.8
12 Section: misc
13 Homepage: https://launchpad.net/ubuntu-terminal-app
14@@ -32,6 +33,7 @@
15 qml-module-qt-labs-settings,
16 qml-module-qtsysteminfo (>= 5.0~),
17 qtdeclarative5-ubuntu-ui-extras0.2,
18+ qtdeclarative5-gsettings1.0,
19 Description: Terminal application
20 Core Terminal application
21
22
23=== modified file 'debian/rules'
24--- debian/rules 2017-03-14 13:43:01 +0000
25+++ debian/rules 2017-04-05 14:42:17 +0000
26@@ -11,7 +11,7 @@
27 dh_auto_configure -- -DCLICK_MODE=OFF
28
29 # Skip tests on the archs they are known to be flaky with current configuration
30-testskip_architectures := powerpc
31+testskip_architectures := arm64 powerpc
32
33 override_dh_auto_test:
34 ifneq ($(DEB_HOST_ARCH),$(findstring $(DEB_HOST_ARCH), $(testskip_architectures)))
35
36=== modified file 'src/app/qml/Settings/SettingsWindow.qml'
37--- src/app/qml/Settings/SettingsWindow.qml 2016-11-29 11:54:38 +0000
38+++ src/app/qml/Settings/SettingsWindow.qml 2017-04-05 14:42:17 +0000
39@@ -23,7 +23,7 @@
40 id: settingsWindow
41
42 visible: true
43- title: "Terminal"
44+ title: i18n.tr("Terminal Preferences")
45 color: settingsPage.windowColor
46 contentOrientation: Screen.orientation
47
48
49=== modified file 'src/app/qml/TerminalPage.qml'
50--- src/app/qml/TerminalPage.qml 2017-01-09 14:56:06 +0000
51+++ src/app/qml/TerminalPage.qml 2017-04-05 14:42:17 +0000
52@@ -20,6 +20,7 @@
53 import Ubuntu.Components.Popups 1.3
54 import Ubuntu.Components.Extras 0.3
55 import QMLTermWidget 1.0
56+import GSettings 1.0
57
58 // For FastBlur
59 import QtGraphicalEffects 1.0
60@@ -180,9 +181,14 @@
61 visible: terminalPage.narrowLayout
62 }
63
64+ GSettings {
65+ id: unity8Settings
66+ schema.id: "com.canonical.Unity8"
67+ }
68+
69 Loader {
70 id: keyboardButton
71- active: !QuickUtils.keyboardAttached
72+ active: !QuickUtils.keyboardAttached || unity8Settings.alwaysShowOsk
73 anchors {right: parent.right; margins: units.gu(1)}
74
75 y: parent.height - height - units.gu(1) - keyboardBarLoader.height
76
77=== modified file 'src/app/qml/helpers.js'
78--- src/app/qml/helpers.js 2016-12-08 11:13:34 +0000
79+++ src/app/qml/helpers.js 2017-04-05 14:42:17 +0000
80@@ -1,7 +1,7 @@
81 function createComponentInstance(component, parent, properties, callback) {
82 var incubator;
83 if (component.status == Component.Ready) {
84- incubator = component.incubateObject(parent, properties, Qt.Asynchronous);
85+ incubator = component.incubateObject(parent, properties, Qt.Synchronous);
86
87 function objectCreated(status) {
88 if (status == Component.Ready && callback != null) {
89
90=== modified file 'src/plugin/qmltermwidget/lib/TerminalDisplay.cpp'
91--- src/plugin/qmltermwidget/lib/TerminalDisplay.cpp 2017-01-16 16:00:10 +0000
92+++ src/plugin/qmltermwidget/lib/TerminalDisplay.cpp 2017-04-05 14:42:17 +0000
93@@ -413,9 +413,7 @@
94 _scrollBar->setVisible(false);
95 connect(_scrollBar, SIGNAL(valueChanged(int)), this, SIGNAL(scrollbarParamsChanged(int)));
96
97- // TODO Forcing rendering to Framebuffer. We need to determine if this is ok
98- // always or if we need to make this customizable.
99- setRenderTarget(QQuickPaintedItem::FramebufferObject);
100+ setRenderTarget(QQuickPaintedItem::Image);
101
102 // Enable drag and drop
103 // setAcceptDrops(true); // attempt

Subscribers

People subscribed via source and target branches