Ubuntu Shorts App

Merge lp:~fboucault/ubuntu-rssreader-app/remove_use_of_theming into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

  1. remove_use_of_theming
  2. Merge into trunk
Proposed by Florian Boucault
Status: Merged
Approved by: Joey Chan
Approved revision: 15
Merged at revision: 15
Proposed branch: lp:~fboucault/ubuntu-rssreader-app/remove_use_of_theming
Merge into: lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Diff against target: 23 lines (+0/-2)
2 files modified
RssFeedDelegate.qml (+0/-1)
RssFeedPage.qml (+0/-1)
To merge this branch: bzr merge lp:~fboucault/ubuntu-rssreader-app/remove_use_of_theming
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Shorts Developers Pending
Review via email: mp+171691@code.launchpad.net

Commit message

Remove non-useful use of ItemStyle.
ItemStyle is about to be deprecated.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'RssFeedDelegate.qml'
2--- RssFeedDelegate.qml 2013-04-17 08:48:48 +0000
3+++ RssFeedDelegate.qml 2013-06-26 23:51:26 +0000
4@@ -52,7 +52,6 @@
5
6 // Label
7 // {
8-//// ItemStyle.class: "button"
9 // fontSize: "large"
10 // text: "Yahoo Top Stories"
11 // }
12
13=== modified file 'RssFeedPage.qml'
14--- RssFeedPage.qml 2013-04-17 08:48:48 +0000
15+++ RssFeedPage.qml 2013-06-26 23:51:26 +0000
16@@ -73,7 +73,6 @@
17 id: label_title
18 anchors.centerIn: parent
19 width: parent.width - units.gu(2)
20- ItemStyle.class: "title"
21 wrapMode: Text.WrapAtWordBoundaryOrAnywhere
22 text: rsstitle
23 color: "white"

Subscribers

People subscribed via source and target branches