Merge lp:~fboucault/ubuntu-calculator-app/noqmlproject into lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk

Proposed by Florian Boucault
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 316
Merged at revision: 325
Proposed branch: lp:~fboucault/ubuntu-calculator-app/noqmlproject
Merge into: lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk
Diff against target: 54 lines (+4/-35)
2 files modified
CMakeLists.txt (+4/-0)
ubuntu-calculator-app.qmlproject (+0/-35)
To merge this branch: bzr merge lp:~fboucault/ubuntu-calculator-app/noqmlproject
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Riccardo Padovani Approve
Mihir Soni Approve
Review via email: mp+232311@code.launchpad.net

Commit message

Remove the need for a qmlproject by listing all the QML files in CMakeLists.txt

Description of the change

Remove the need for a qmlproject by listing all the QML files in CMakeLists.txt

To post a comment you must log in.
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good to me thanks for the MR.

review: Approve
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

lgtm, thanks

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-05-16 20:21:54 +0000
3+++ CMakeLists.txt 2014-08-26 20:13:38 +0000
4@@ -16,6 +16,10 @@
5 set(APP_HARDCODE ubuntu-calculator-app)
6 set(MAIN_QML ${APP_HARDCODE}.qml)
7
8+# make non compiled files visible in qtcreator
9+file(GLOB_RECURSE NON_COMPILED_FILES *.qml *.js *.py *.svg *.png *.in *.json *.desktop *.pot qmldir)
10+add_custom_target(NON_COMPILED_TARGET ALL SOURCES ${NON_COMPILED_FILES})
11+
12 if(CLICK_MODE)
13 if(NOT DEFINED BZR_SOURCE)
14 set(BZR_SOURCE "lp:${APP_HARDCODE}")
15
16=== removed file 'ubuntu-calculator-app.qmlproject'
17--- ubuntu-calculator-app.qmlproject 2014-06-06 07:31:42 +0000
18+++ ubuntu-calculator-app.qmlproject 1970-01-01 00:00:00 +0000
19@@ -1,35 +0,0 @@
20-/* File generated by Qt Creator, version 2.6.1 */
21-
22-import QmlProject 1.1
23-
24-Project {
25- mainFile: "ubuntu-calculator-app.qml"
26-
27- /* Include .qml, .js, and image files from current directory and subdirectories */
28- QmlFiles {
29- directory: "."
30- }
31- JavaScriptFiles {
32- directory: "."
33- }
34- ImageFiles {
35- directory: "."
36- }
37- /* Shows the README files in the project view */
38- Files {
39- filter: "README*"
40- }
41- /* Shows the translation files and the .pot template */
42- Files {
43- filter: "*.po*"
44- }
45- Files {
46- filter: "CMakeLists.txt"
47- }
48- /* Shows the desktop file in the project view */
49- Files {
50- filter: "*.desktop*"
51- }
52- /* List of plugin directories passed to QML runtime */
53- importPaths: [ "." ,"/usr/lib/x86_64-linux-gnu/qt5/qml" ]
54-}

Subscribers

People subscribed via source and target branches