Merge lp:~fboucault/telegram-app/splash_fixes into lp:telegram-app
Proposed by
Florian Boucault
on 2016-01-16
| Status: | Rejected |
|---|---|
| Rejected by: | Michał Karnicki on 2016-01-18 |
| Proposed branch: | lp:~fboucault/telegram-app/splash_fixes |
| Merge into: | lp:telegram-app |
| Diff against target: |
12 lines (+1/-1) 1 file modified
telegram/app/telegram.desktop (+1/-1) |
| To merge this branch: | bzr merge lp:~fboucault/telegram-app/splash_fixes |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michał Karnicki (community) | 2016-01-16 | Abstain on 2016-01-18 | |
| Florian Boucault (community) | Disapprove on 2016-01-18 | ||
|
Review via email:
|
|||
Commit Message
Made startup splashscreen better: turn header mode on.
To post a comment you must log in.
| Michał Karnicki (karni) wrote : | # |
As discussed on IRC, splash had no header mostly due to this case:
1. splash (with header)
(first app launch)
2. tutorial (no header, full screen)
3. app (with header)
so the transition looked weird. As starting the app for first time is less common than regular start, I guess we could discuss this (or ask Design). TBH I have no strong preference on this, though I recognize the described case above indeed looked ugly :)
review:
Abstain
Unmerged revisions
- 141. By Florian Boucault on 2016-01-16
-
Made startup splashscreen better: turn header mode on.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
After debate with karni, not necessary