Merge lp:~fboucault/camera-app/swipe_no_zoom into lp:camera-app

Proposed by Florian Boucault
Status: Merged
Approved by: Bill Filler
Approved revision: 496
Merged at revision: 499
Proposed branch: lp:~fboucault/camera-app/swipe_no_zoom
Merge into: lp:camera-app
Diff against target: 19 lines (+9/-0)
1 file modified
SlideshowView.qml (+9/-0)
To merge this branch: bzr merge lp:~fboucault/camera-app/swipe_no_zoom
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+248968@code.launchpad.net

Commit message

Swiping quickly through photo roll no longer causes photos to zoom. Workaround for QTBUG-39332.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'SlideshowView.qml'
2--- SlideshowView.qml 2015-01-28 11:42:09 +0000
3+++ SlideshowView.qml 2015-02-06 21:01:56 +0000
4@@ -239,6 +239,15 @@
5 mouse.accepted = false;
6 }
7 onDoubleClicked: {
8+ if (listView.moving) {
9+ // FIXME: workaround for Qt bug specific to touch:
10+ // doubleClicked is received even though the MouseArea
11+ // was tapped only once but another MouseArea was also
12+ // tapped shortly before.
13+ // Ref.: https://bugreports.qt.io/browse/QTBUG-39332
14+ return;
15+ }
16+
17 if (media.isVideo) {
18 return;
19 }

Subscribers

People subscribed via source and target branches