Merge lp:~fboucault/camera-app/grid_slideshow_exclusive into lp:camera-app

Proposed by Florian Boucault
Status: Merged
Approved by: Ugo Riboni
Approved revision: 462
Merged at revision: 485
Proposed branch: lp:~fboucault/camera-app/grid_slideshow_exclusive
Merge into: lp:camera-app
Diff against target: 21 lines (+2/-2)
1 file modified
GalleryView.qml (+2/-2)
To merge this branch: bzr merge lp:~fboucault/camera-app/grid_slideshow_exclusive
Reviewer Review Type Date Requested Status
Ugo Riboni (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+246181@code.launchpad.net

Commit message

Improve thumbnail generation performance: do not retrieve thumbnails for the view that is not visible.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ugo Riboni (uriboni) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'GalleryView.qml'
2--- GalleryView.qml 2014-12-05 18:50:53 +0000
3+++ GalleryView.qml 2015-01-12 16:30:52 +0000
4@@ -70,7 +70,7 @@
5 anchors.fill: parent
6 model: galleryView.model
7 visible: opacity != 0.0
8- inView: galleryView.inView
9+ inView: galleryView.inView && galleryView.currentView == slideshowView
10 onToggleHeader: header.toggle();
11 }
12
13@@ -81,7 +81,7 @@
14 userSelectionMode: galleryView.userSelectionMode
15 model: galleryView.model
16 visible: opacity != 0.0
17- inView: galleryView.inView
18+ inView: galleryView.inView && galleryView.currentView == photogridView
19 inSelectionMode: main.contentExportMode || galleryView.userSelectionMode
20 onPhotoClicked: {
21 slideshowView.showPhotoAtIndex(index);

Subscribers

People subscribed via source and target branches