~fandanbango/charm-juju-backup-all:omit-models

Branch merges

Propose for merging

Rejected for merging into charm-juju-backup-all:master

🤖 prod-jenkaas-bootstack (community): Needs Fixing (continuous-integration) on 2022-10-13

Eric Chen: Needs Information on 2022-09-12

Sudeep Bhandari: Approve on 2022-09-12

Robert Gildein: Approve on 2022-08-30

BootStack Reviewers: Pending requested 2022-08-30

Diff: 307 lines (+150/-13)

8 files modified

actions.yaml (+6/-0)
config.yaml (+4/-0)
scripts/templates/auto_backup.py (+11/-3)
src/charm.py (+6/-1)
src/utils.py (+20/-6)
tests/fixtures.py (+1/-0)
tests/unit/test_charm.py (+57/-2)
tests/unit/test_utils.py (+45/-1)

api

Superseded for merging into charm-juju-backup-all:master

BootStack Reviewers: Pending requested 2022-08-30

Canonical BootStack Charmers: Pending requested 2022-08-30

Diff: 452 lines (+223/-28)

10 files modified

actions.yaml (+6/-0)
config.yaml (+4/-0)
requirements-dev.txt (+1/-1)
scripts/templates/auto_backup.py (+13/-4)
src/charm.py (+6/-1)
src/utils.py (+30/-15)
tests/fixtures.py (+3/-0)
tests/unit/test_charm.py (+57/-2)
tests/unit/test_utils.py (+102/-4)
tox.ini (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

25a132a... by Facundo Ciccioli on 2022-08-30

Adjust tests for the omitting models' feature

In the way, fix the cronjob command, which was passing a CSV as the only
--omit-models parameter, but that was not having the intended effect on
the auto_backup.py script.

358593b... by Ksawery Dziekoński on 2022-06-29

Allow for model omission in controller-wide backups

Related: LP#1980215

89a0899... by Facundo Ciccioli on 2022-08-29

Disable DEBUG logging

6bec7d0... by Facundo Ciccioli on 2022-08-29

Make linter happy

faccc55... by Facundo Ciccioli on 2022-08-29

Make linter work again

7a26576... by Facundo Ciccioli on 2022-08-29

Complete perform_backup test and create update_crontab's

0b07b23... by Facundo Ciccioli on 2022-08-29

Fix the asyncio issue

Applying Robert Gildein's fix to the asyncio issue, his words:

I could reproduce this only on 3.8.10 Python, on 3.10.4 is not there.

To fix this you need to use model = mock.MagicMock() instead of
model = mock.Mock(). Why? Not sure, libjuju required

   websockets<8.0,>=7.0; python_version < "3.9"

and if I install version 10.3 the issue disappears.

IMO it's ok to ignore that issue.

4e195d3... by Facundo Ciccioli on 2022-08-26

[WIP] Add unit test for JujuBackupAllHelper.perform_backup()

NOTE: Tests as they are are failing due to some asyncio issue. Skipping
the test_perform_backup test makes them pass.

9640489... by Sudeep Bhandari on 2022-08-18

Specified architecture: amd64

Reviewed-on: https://code.launchpad.net/~sudeephb/charm-juju-backup-all/+git/charm-juju-backup-all/+merge/428532
Reviewed-by: Eric Chen <email address hidden>

e9880d9... by Sudeep Bhandari on 2022-08-18

explicitly specified arch: amd64