Merge lp:~fahad-k/linaro-image-tools/linaro-image-tools into lp:linaro-image-tools/11.11

[Данило Шеган]

Changes to add support for Origen quad.

[Данило Шеган (danilo)]

Fahad, thanks for working on this.

There is no need to copy the entire method from boards.SamsungConfig.populate_raw_partition. The idea is that you can override SAMSUNG_V310_BL2_START by setting it on AndroidOrigenquadConfig class directly.

You can add extra boot parameters in 'android_specific_args' (see implementation of other classes) or 'extra_boot_args_options'. Look at _get_bootargs() implementation to see how they are constructed using _extra_serial_opts (you should not have to modify this) as well.

Note that we'll also needs tests for these changes.

[lp:~fahad-k/linaro-image-tools/linaro-image-tools]

588. By Fahad Kunnathadi on 2012-11-23

Support for flashing origen quad 4412 u-boot

[Fahad Kunnathadi (fahad-k)]

Hi danilo,thanks for the comment

After modification I ve added changes to this branch, after an name change
https://code.launchpad.net/~fahad-k/linaro-image-tools/lp1081714-support-4412-flashing

i've set this boot envs in AndroidOrigenquadConfig class, but this dont reflect.

 _extra_serial_opts = 'console=tty0 console=ttySAC2,115200n8'
 android_specific_args = 'rootwait ro root=/dev/mmcblk0p2
           init=/init androidboot.console=ttySAC2'
kernel_addr = '0x40007000'
initrd_addr = '0x42000000'
load_addr = '0x40007000'
mmc_part_offset = 1
mmc_option = '0:2'
any changes over this variable, iseent reflecting in u-boot, is this the way .

[Данило Шеган (danilo)]

I can see changes reflected in boot.scr/boot.txt on the boot partition with the changes like:

  https://pastebin.linaro.org/1102/

[Данило Шеган (danilo)]

After long discussion with Fahad on IRC, it seems that unlike Linaro's u-boot implementation, origen quad u-boot doesn't load boot.scr from the boot partition, which is an interface that linaro-image-tools supports.

linaro-image-tools can do anything else as well, but that requires understanding of the provided u-boot implementation and how can linaro-image-tools specify boot arguments. We'd, naturally, prefer if origen quad u-boot did the same thing all the other boards did and simply sourced 'boot.scr'.

As agreed with Fahad, this will require more investigative work. I'll also mark the bug as 'incomplete', since we can't really do much without understanding how to proceed (either Linaro u-boot is used, or insignal one, or details are provided on exactly how boot environment needs to be set up for the boot to work).

review: Disapprove

Unmerged revisions

588. By Fahad Kunnathadi on 2012-11-23

Support for flashing origen quad 4412 u-boot

=== modified file 'linaro_image_tools/media_create/android_boards.py'
--- linaro_image_tools/media_create/android_boards.py	2012-10-17 10:48:49 +0000
+++ linaro_image_tools/media_create/android_boards.py	2012-11-23 15:44:21 +0000
@@ -348,6 +348,11 @@
     android_specific_args = 'init=/init androidboot.console=ttySAC2'
     dtb_name = None
 
+class AndroidOrigenquadConfig(AndroidSamsungConfig, OrigenConfig):
+    _extra_serial_opts = 'console=tty0 console=ttySAC2,115200n8'
+    android_specific_args = 'init=/init androidboot.console=ttySAC2'
+    SAMSUNG_V310_BL2_START=49
+
 
 class AndroidVexpressConfig(AndroidBoardConfig, VexpressConfig):
     _extra_serial_opts = 'console=tty0 console=ttyAMA0,38400n8'
@@ -365,6 +370,7 @@
     'iMX53': AndroidMx53LoCoConfig,
     'mx6qsabrelite': AndroidMx6QSabreliteConfig,
     'origen': AndroidOrigenConfig,
+    'origenquad': AndroidOrigenquadConfig,
     'vexpress': AndroidVexpressConfig,
     'vexpress-a9': AndroidVexpressConfig,
     }