Code review comment for lp:~fahad-aizaz/hipl/hip-cert-conf

Hi Fahad!

 review abstain

The code 'changes' look good to me, but I cannot comment on the
packaging stuff.

> While doing so, I observed that the configuration file though
> referenced in the code for reading, but I didn't find any trigger to
> actually read the contents of the file. That is, the function that
> reads the configuration file section by section, is not being called
> though its definition exist.

Which one is the function for reading the config file?
hip_cert_x509v3_handle_request_to_sign? Isn't that one called in
hipd/user.c?

Stefan

review: Abstain

« Back to merge proposal