Code review comment for lp:~fahad-aizaz/hipl/cert-config

Fahad Aizaz (fahad-aizaz) wrote :

On 02/21/2012 02:23 PM, Diego Biurrun wrote:
> Review: Needs Information
>
> review needs-info
>
> On Mon, Feb 20, 2012 at 09:56:24PM +0000, Fahad Aizaz wrote:
>> Fahad Aizaz has proposed merging lp:~fahad-aizaz/hipl/cert-config into lp:hipl.
>
> I don't think this is compatible with the pisa certificate branch.

In a way you are absolutely right. As far as I could look into the code,
I didn't find any references to certificate generation, signing etc.
Perhaps that what Renè meant, to introduce a complete certificates
functionality.

I removed certtools.c/h and moving from there removed the code that
either depends on the functions defined in this file or functions that
are referenced from the functions in this file.

I am not sure, whether this part of the code was being used by anyother
part of hipl codebase other than the test code.

regards,
Fahad

« Back to merge proposal