Merge lp:~fagerstedt-axel/lava-android-test/linaro-android-kernel-test into lp:lava-android-test

Proposed by Axel Fagerstedt
Status: Merged
Merged at revision: 237
Proposed branch: lp:~fagerstedt-axel/lava-android-test/linaro-android-kernel-test
Merge into: lp:lava-android-test
Diff against target: 95 lines (+32/-35)
3 files modified
doc/tests.rst (+3/-3)
lava_android_test/test_definitions/commands/ashmemtest.py (+0/-32)
lava_android_test/test_definitions/commands/linaro_android_kernel_test.py (+29/-0)
To merge this branch: bzr merge lp:~fagerstedt-axel/lava-android-test/linaro-android-kernel-test
Reviewer Review Type Date Requested Status
Yongqin Liu Approve
Review via email: mp+148501@code.launchpad.net

Description of the change

Adds a new test, linaro_android_kernel_test, this will run all the linaro android kernel unit tests.

Ashmemtest is removed as it will be run by the new test.

To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Seems reasonable to me. Could these tests be run with lava-test-shell?
That's becoming the prefered way to do things if you don't need to
fiddle with adb specifically.

Revision history for this message
Axel Fagerstedt (fagerstedt-axel) wrote :

It would absolutely make sense to run it as lava-test-shell

Last I head android-build does not yet support posting lava-test-shell jobs (being worked on) so I did this first, next step will be to publish a lava-test-shell definition.

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

Hi, Axel

just some questions:
1. is the linaro-android-kernel-tests.sh integrated into the build?
2. could you list some output to help to check if the pattern is right?
3. The following two lines should be unnecessary.
93 +import lava_android_test.testdef
95 +test_name = 'linaro_android_kernel_test'

Revision history for this message
Axel Fagerstedt (fagerstedt-axel) wrote :

1. yes (in the juice builds)

2. here is some example output (I have tested the parsing locally)

Running basic ashmemtest.
0 [ashmem_basic]: test passed

Running expanded ashmemtest.
running test0
-> got 1000 pages -> unpin 0..500 OK ret 0 -> pin 0..500 OK ret 0
[test0]: test passed

Running alarm dev test.
Error opening /dev/alarm
[alarmdevtest]: test failed

3. verifying and will upload a updated version shortly

237. By Axel Fagerstedt

linaro_android_kernel_test cleanup

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

liuyq> from the output, seem the result gotten by the pattern is failed or passed.
<liuyq> I am not very sure if the result of failed or passed can be accepted
<liuyq> could you help to run "lava-android-test run command-linaro_android_kernel_test -o result.json", and see if we can get the result in the result.json file?
<liuyq> if the command works well, then the source should be ok

And maybe we can rename the file name to kernel.py from linaro_android_kernel_test.py for a short.

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

<axelfagerstedt> I would prefer not to rename the suite to kernel.py as i believe there are other linaro test suites testing kernel functionality. This one is specifically testing android drivers.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'doc/tests.rst'
2--- doc/tests.rst 2013-01-21 18:02:32 +0000
3+++ doc/tests.rst 2013-02-26 08:42:20 +0000
4@@ -22,7 +22,7 @@
5 * `v8`_
6 * `wifi`_
7 * `0xbench`_
8- * `ashmemtest`_
9+ * `linaro_android_kernel_test`_
10 * `commands`_
11 * `instruments`_
12 * `hostshells`_
13@@ -88,9 +88,9 @@
14 ++++
15 .. automodule:: lava_android_test.test_definitions.wifi
16
17-ashmemtest
18+linaro_android_kernel_test
19 ++++++++
20-.. automodule:: lava_android_test.test_definitions.commands.ashmemtest
21+.. automodule:: lava_android_test.test_definitions.commands.linaro_android_kernel_test
22
23 commands
24 ++++++++
25
26=== removed file 'lava_android_test/test_definitions/commands/ashmemtest.py'
27--- lava_android_test/test_definitions/commands/ashmemtest.py 2013-02-01 17:09:26 +0000
28+++ lava_android_test/test_definitions/commands/ashmemtest.py 1970-01-01 00:00:00 +0000
29@@ -1,32 +0,0 @@
30-# Copyright (c) 2012 Linaro
31-
32-# Author: Linaro Validation Team <linaro-dev@lists.linaro.org>
33-#
34-# This file is part of LAVA Android Test.
35-#
36-#
37-# This program is free software: you can redistribute it and/or modify
38-# it under the terms of the GNU General Public License as published by
39-# the Free Software Foundation, either version 3 of the License, or
40-# (at your option) any later version.
41-#
42-# This program is distributed in the hope that it will be useful,
43-# but WITHOUT ANY WARRANTY; without even the implied warranty of
44-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
45-# GNU General Public License for more details.
46-#
47-# You should have received a copy of the GNU General Public License
48-# along with this program. If not, see <http://www.gnu.org/licenses/>.
49-"""
50-Runs the basic and expanded unit tests for the ashmem driver.
51-
52-**URL:** None
53-
54-**Default Options:** None
55-"""
56-import lava_android_test.testdef
57-
58-test_name = 'ashmem'
59-
60-RUN_ADB_SHELL_STEPS = ['ashmemtest', 'ashmemtest-expanded-runner.sh']
61-PATTERN = "\s*\[(?P<test_case_id>\w+)\]:\s\w+\s(?P<result>\w+)"
62
63=== added file 'lava_android_test/test_definitions/commands/linaro_android_kernel_test.py'
64--- lava_android_test/test_definitions/commands/linaro_android_kernel_test.py 1970-01-01 00:00:00 +0000
65+++ lava_android_test/test_definitions/commands/linaro_android_kernel_test.py 2013-02-26 08:42:20 +0000
66@@ -0,0 +1,29 @@
67+# Copyright (c) 2012 Linaro
68+
69+# Author: Linaro Validation Team <linaro-dev@lists.linaro.org>
70+#
71+# This file is part of LAVA Android Test.
72+#
73+#
74+# This program is free software: you can redistribute it and/or modify
75+# it under the terms of the GNU General Public License as published by
76+# the Free Software Foundation, either version 3 of the License, or
77+# (at your option) any later version.
78+#
79+# This program is distributed in the hope that it will be useful,
80+# but WITHOUT ANY WARRANTY; without even the implied warranty of
81+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
82+# GNU General Public License for more details.
83+#
84+# You should have received a copy of the GNU General Public License
85+# along with this program. If not, see <http://www.gnu.org/licenses/>.
86+"""
87+Runs the linaro kernel unit tests
88+
89+**URL:** None
90+
91+**Default Options:** None
92+"""
93+
94+RUN_ADB_SHELL_STEPS = ['linaro-android-kernel-tests.sh']
95+PATTERN = "\s*\[(?P<test_case_id>\w+)\]:\s\w+\s(?P<result>\w+)"

Subscribers

People subscribed via source and target branches