Merge lp:~facundo/ubuntuone-client/lr-stop-nonutf8 into lp:ubuntuone-client
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Facundo Batista | ||||
Approved revision: | 1111 | ||||
Merged at revision: | 1119 | ||||
Proposed branch: | lp:~facundo/ubuntuone-client/lr-stop-nonutf8 | ||||
Merge into: | lp:ubuntuone-client | ||||
Diff against target: |
117 lines (+66/-6) 2 files modified
tests/syncdaemon/test_localrescan.py (+32/-1) ubuntuone/syncdaemon/local_rescan.py (+34/-5) |
||||
To merge this branch: | bzr merge lp:~facundo/ubuntuone-client/lr-stop-nonutf8 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Facundo Batista (community) | Approve | ||
Natalia Bidart (community) | Approve | ||
Review via email: mp+72452@code.launchpad.net |
Commit message
Ignore non utf8 paths in LR (LP: #696901).
Description of the change
Ignore non utf8 paths in LR.
The one that should check if the path is valid is LocalRescan. It can't be done in the signals processors (that are close to real validation, in the freeze_commit stage).
The reason for this is that if LR finds an invalid path it needs to ignore it; in files there is no problem, but for directories it shouldn't scan that directory later.
So, I added a function in LR, very similar to the one in in platform/
Tests included, and also added logging when ignoring the path because of symlink.
Looks great!