Ubuntu One Client

Merge lp:~facundo/ubuntuone-client/check_path_with_repr into lp:ubuntuone-client

  1. check_path_with_repr
  2. Merge into trunk
Proposed by Facundo Batista
Status: Merged
Approved by: Natalia Bidart
Approved revision: 1124
Merged at revision: 1125
Proposed branch: lp:~facundo/ubuntuone-client/check_path_with_repr
Merge into: lp:ubuntuone-client
Diff against target: 64 lines (+7/-7)
1 file modified
tests/syncdaemon/test_sync.py (+7/-7)
To merge this branch: bzr merge lp:~facundo/ubuntuone-client/check_path_with_repr
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Review via email: mp+73796@code.launchpad.net

Commit message

Check paths with repr in sync tests (LP: #839505).

Description of the change

Check paths with repr in sync tests.

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Looks great!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/syncdaemon/test_sync.py'
2--- tests/syncdaemon/test_sync.py 2011-09-01 19:50:22 +0000
3+++ tests/syncdaemon/test_sync.py 2011-09-02 12:29:01 +0000
4@@ -742,7 +742,7 @@
5 self.sync.handle_FS_FILE_CREATE(somepath)
6 self.assertFalse(called)
7 should_logged = ("FS_FILE_CREATE", "discarded",
8- "volume not subscribed", somepath)
9+ "volume not subscribed", repr(somepath))
10 self.assertTrue(self.handler.check_debug(*should_logged))
11
12 @defer.inlineCallbacks
13@@ -760,7 +760,7 @@
14 self.sync.handle_FS_DIR_CREATE(somepath)
15 self.assertFalse(called)
16 should_logged = ("FS_DIR_CREATE", "discarded",
17- "volume not subscribed", somepath)
18+ "volume not subscribed", repr(somepath))
19 self.assertTrue(self.handler.check_debug(*should_logged))
20
21 @defer.inlineCallbacks
22@@ -779,7 +779,7 @@
23 self.sync.handle_FS_FILE_DELETE(somepath)
24 self.assertFalse(called)
25 should_logged = ("FS_FILE_DELETE", "discarded",
26- "volume not subscribed", somepath)
27+ "volume not subscribed", repr(somepath))
28 self.assertTrue(self.handler.check_debug(*should_logged))
29
30 @defer.inlineCallbacks
31@@ -798,7 +798,7 @@
32 self.sync.handle_FS_DIR_DELETE(somepath)
33 self.assertFalse(called)
34 should_logged = ("FS_DIR_DELETE", "discarded",
35- "volume not subscribed", somepath)
36+ "volume not subscribed", repr(somepath))
37 self.assertTrue(self.handler.check_debug(*should_logged))
38
39 @defer.inlineCallbacks
40@@ -817,7 +817,7 @@
41 self.sync.handle_FS_FILE_MOVE(somepath, 'otherpath')
42 self.assertFalse(called)
43 should_logged = ("FS_FILE_MOVE", "discarded",
44- "volume not subscribed", somepath)
45+ "volume not subscribed", repr(somepath))
46 self.assertTrue(self.handler.check_debug(*should_logged))
47
48 @defer.inlineCallbacks
49@@ -836,7 +836,7 @@
50 self.sync.handle_FS_DIR_MOVE(somepath, 'otherpath')
51 self.assertFalse(called)
52 should_logged = ("FS_DIR_MOVE", "discarded",
53- "volume not subscribed", somepath)
54+ "volume not subscribed", repr(somepath))
55 self.assertTrue(self.handler.check_debug(*should_logged))
56
57 @defer.inlineCallbacks
58@@ -855,7 +855,7 @@
59 self.sync.handle_FS_FILE_CLOSE_WRITE(somepath)
60 self.assertFalse(called)
61 should_logged = ("FS_FILE_CLOSE_WRITE", "discarded",
62- "volume not subscribed", somepath)
63+ "volume not subscribed", repr(somepath))
64 self.assertTrue(self.handler.check_debug(*should_logged))
65
66

Subscribers

People subscribed via source and target branches