Merge lp:~facundo/txstatsd/non-blocking-sockets into lp:txstatsd

[Facundo Batista]

Make the UDP socket not blocking.

Make the UDP socket not blocking.

Tests included.

[Sidnei da Silva (sidnei)]

Looks good!

I'll merge it manually since there's a typo in the test function name.

review: Approve

=== modified file 'txstatsd/client.py'
--- txstatsd/client.py	2011-09-06 15:24:29 +0000
+++ txstatsd/client.py	2011-10-20 22:59:24 +0000
@@ -62,7 +62,7 @@
 
     def write(self, data, callback=None):
         """Send the metric to the StatsD server.
-                
+
         @param data: The data to be sent.
         @param callback: The callback to which the result should be sent.
             B{Note}: The C{callback} will be called in the C{reactor}
@@ -72,7 +72,7 @@
 
     def _write(self, data, callback):
         """Send the metric to the StatsD server.
-                
+
         @param data: The data to be sent.
         @param callback: The callback to which the result should be sent.
         @raise twisted.internet.error.MessageLengthError: If the size of data
@@ -113,6 +113,7 @@
     def connect(self):
         """Connect to the StatsD server."""
         self.socket = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
+        self.socket.setblocking(0)
 
     def disconnect(self):
         """Disconnect from the StatsD server."""

=== modified file 'txstatsd/tests/test_client.py'
--- txstatsd/tests/test_client.py	2011-09-08 12:52:16 +0000
+++ txstatsd/tests/test_client.py	2011-10-20 22:59:24 +0000
@@ -64,3 +64,8 @@
                           UdpStatsDClient, 'localhost', 'malformed')
         self.assertRaises(ValueError,
                           UdpStatsDClient, 0, 8000)
+
+    def test_idpstatsd_socket_nonblocking(self):
+        client = UdpStatsDClient('localhost', 8000)
+        client.connect()
+        self.assertEqual(client.socket.gettimeout(), 0.0)