Merge lp:~facundo/magicicada-gui/alert-when-initial-data into lp:magicicada-gui

[Facundo Batista]

When the SD has all the initial data, call the callback.

[Natalia Bidart (nataliabidart)]

Awesome!

review: Approve

=== modified file 'magicicada/syncdaemon.py'
--- magicicada/syncdaemon.py	2010-07-08 22:34:16 +0000
+++ magicicada/syncdaemon.py	2010-07-21 23:21:00 +0000
@@ -107,6 +107,7 @@
         self.on_shares_to_me_changed_callback = NO_OP
         self.on_shares_to_others_changed_callback = NO_OP
         self.on_metadata_ready_callback = None  # mandatory
+        self.on_initial_data_ready_callback = NO_OP
 
         # mq needs to be polled to know progress
         self._mqcaller = None
@@ -147,6 +148,10 @@
         self.shares_to_me = yield self.dbus.get_shares_to_me()
         self.shares_to_others = yield self.dbus.get_shares_to_others()
 
+        # let frontend know that we have all the initial data
+        logger.info("All initial data is ready")
+        self.on_initial_data_ready_callback()
+
     @defer.inlineCallbacks
     def on_sd_shares_changed(self):
         """Shares changed, ask for new information."""

=== modified file 'magicicada/tests/test_syncdaemon.py'
--- magicicada/tests/test_syncdaemon.py	2010-07-08 22:37:44 +0000
+++ magicicada/tests/test_syncdaemon.py	2010-07-21 23:21:00 +0000
@@ -700,6 +700,13 @@
                                      False, 'queues', 'connection')
         self.assertTrue(self.called)
 
+    @defer.inlineCallbacks
+    def test_on_initial_data_ready(self):
+        """Called when SD gets all the initial data."""
+        self.flag_called(self.sd, 'on_initial_data_ready_callback')
+        yield self.sd._get_initial_data()
+        self.assertTrue(self.called)
+
 
 class TestLogs(unittest.TestCase):
     """Test logging."""
@@ -730,6 +737,7 @@
         """Log the initial filling."""
         yield self.sd._get_initial_data()
         self.assertTrue(self.hdlr.check_info("Getting initial data"))
+        self.assertTrue(self.hdlr.check_info("All initial data is ready"))
 
     def test_start(self):
         """Log the call to start."""