Merge lp:~facundo/lalita/hal-retry into lp:~verterok/lalita/hal

[Facundo Batista]

Retry when getting errors from LP.

Retry when getting errors from LP.

[Guillermo Gonzalez (verterok)]

thanks!

review: Approve

=== modified file 'lalita/plugins/launchpad.py'
--- lalita/plugins/launchpad.py	2012-09-21 19:32:08 +0000
+++ lalita/plugins/launchpad.py	2013-04-24 20:03:26 +0000
@@ -353,12 +353,33 @@
                                   format_age(c.date_created),
                                   c.registrant.name)
 
+    def iter_project_candidates(self, show, projects, condition):
+        """Get the candidates per project."""
+        for p in projects:
+            self.logger.debug('fetching landing candidates for %r', p)
+            attempt = 0
+            while attempt < 3:
+                attempt += 1
+                try:
+                    candidates = self.iter_candidates_project(p, condition)
+                except lazr_errors.HTTPError, err:
+                    resp = err.response
+                    error_msg = "(%s) %s" % (resp['status'],
+                                             getattr(resp, 'reason', None))
+                    self.logger.debug("Error getting candidates for %r (%d°):"
+                                      " %s", p, attempt, error_msg)
+                else:
+                    for c in candidates:
+                        yield c
+                    break
+            else:
+                show("Error when trying to get info for %r: %s", p, error_msg)
+
     @require_launchpad
     def show_candidates(self, channel, projects, user=None):
         """ fetch the landing candidates and call d.callback. """
         show = functools.partial(reactor.callFromThread,
                                  self._show_candidates, channel)
-        candidates_count = 0
         pending = False
         condition = self.config.get('filters', {}).get(channel)
         if condition:
@@ -370,9 +391,9 @@
         else:
             self.logger.debug('fetching landing candidates: projects: %s - '
                               'condition: %s', projects, condition)
-            candidates = (c for p in projects \
-                          for c in self.iter_candidates_project(
-                              p, condition=condition))
+            candidates = self.iter_project_candidates(show, projects,
+                                                      condition)
+
         for candidate in candidates:
             if not pending:
                 pending = True