Merge lp:~facundo/canonical-identity-provider/add-password-changed-timestamp into lp:canonical-identity-provider/release

[Facundo Batista]

Added a timestamp to flag when the password was changed.

[Daniel Manrique (roadmr)]

May need fixing, see below.

review: Needs Information

[Facundo Batista (facundo)]

Commends addressed

[Daniel Manrique (roadmr)]

LGTM, thanks!

review: Approve

=== added file 'src/identityprovider/migrations/0008_accountpassword_date_changed.py'
--- src/identityprovider/migrations/0008_accountpassword_date_changed.py	1970-01-01 00:00:00 +0000
+++ src/identityprovider/migrations/0008_accountpassword_date_changed.py	2016-03-23 16:24:27 +0000
@@ -0,0 +1,19 @@
+# -*- coding: utf-8 -*-
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('identityprovider', '0007_auto_20160310_2013'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='accountpassword',
+            name='date_changed',
+            field=models.DateTimeField(null=True, editable=False),
+        ),
+    ]

=== modified file 'src/identityprovider/models/account.py'
--- src/identityprovider/models/account.py	2015-11-09 10:41:10 +0000
+++ src/identityprovider/models/account.py	2016-03-23 16:24:27 +0000
@@ -1,4 +1,4 @@
-# Copyright 2010, 2012 Canonical Ltd.  This software is licensed under
+# Copyright 2010-2016 Canonical Ltd.  This software is licensed under
 # the GNU Affero General Public License version 3 (see the file
 # LICENSE).
 
@@ -665,6 +665,7 @@
     account = models.OneToOneField(Account, db_column=b'account')
     password = PasswordField()
     last_leak_check = models.DateTimeField(null=True)
+    date_changed = models.DateTimeField(null=True, editable=False)
 
     LEAK_REFERENCE_DATE = datetime(2000, 01, 01, 0, 0, 0)
 
@@ -687,9 +688,12 @@
 
         Usual "update_fields" behavior applies (i.e. last_leak_check will NOT
         be auto_updated if any fields are specified with update_fields).
+
+        Also, we keep the last time the password was changed.
         """
         if 'last_leak_check' not in kwargs.get('update_fields', []):
             self.last_leak_check = AccountPassword.LEAK_REFERENCE_DATE
+        self.date_changed = now()
         super(AccountPassword, self).save(*args, **kwargs)
 
 

=== modified file 'src/identityprovider/tests/test_models_account.py'
--- src/identityprovider/tests/test_models_account.py	2016-01-07 16:45:57 +0000
+++ src/identityprovider/tests/test_models_account.py	2016-03-23 16:24:27 +0000
@@ -1,4 +1,4 @@
-# Copyright 2010 Canonical Ltd.  This software is licensed under the
+# Copyright 2010-2016 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 
@@ -972,6 +972,19 @@
             AccountPassword.objects.all()[0].last_leak_check,
             AccountPassword.LEAK_REFERENCE_DATE)
 
+    def test_changed_password(self):
+        account = self.factory.make_account()
+
+        # get timestamp from creation
+        created_at = account.accountpassword.date_changed
+
+        # change the password
+        account.accountpassword.password = "Somethingelse"
+        account.accountpassword.save()
+
+        # verify!
+        self.assertGreater(account.accountpassword.date_changed, created_at)
+
 
 class CreateOAuthTokenForAccountTestCase(SSOBaseTestCase):