Merge lp:~fabricematrat/convoy/trunk into lp:convoy
Proposed by
Fabrice Matrat
Status: | Merged |
---|---|
Merged at revision: | 26 |
Proposed branch: | lp:~fabricematrat/convoy/trunk |
Merge into: | lp:convoy |
Diff against target: |
45 lines (+14/-3) 2 files modified
convoy/combo.py (+6/-3) convoy/tests/test_combo.py (+8/-0) |
To merge this branch: | bzr merge lp:~fabricematrat/convoy/trunk |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+244440@code.launchpad.net |
Description of the change
Add the capability to specify a max age for the response.
This will add a cache header on ther esponse
To post a comment you must log in.
I think it would be nicer to set a variable to be the common list of items for both situations that is used as the second parameter to start_response. Then if max_age is not None you could append to the list followed by a single call to start_response.
Otherwise LGTM