Merge lp:~fabiozaramella/pantheon-photos/use-deletable into lp:~pantheon-photos/pantheon-photos/trunk

Proposed by Fabio Zaramella
Status: Merged
Approved by: Danielle Foré
Approved revision: 2722
Merged at revision: 2722
Proposed branch: lp:~fabiozaramella/pantheon-photos/use-deletable
Merge into: lp:~pantheon-photos/pantheon-photos/trunk
Diff against target: 44 lines (+2/-10)
1 file modified
src/Dialogs.vala (+2/-10)
To merge this branch: bzr merge lp:~fabiozaramella/pantheon-photos/use-deletable
Reviewer Review Type Date Requested Status
Photos Devs Pending
Review via email: mp+246849@code.launchpad.net

Commit message

Revert headerbar, set deletable false in dialog

Description of the change

In the same way as noise, scratch etc..

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Dialogs.vala'
2--- src/Dialogs.vala 2014-11-08 13:37:25 +0000
3+++ src/Dialogs.vala 2015-01-18 18:56:57 +0000
4@@ -2070,7 +2070,6 @@
5 private static PreferencesDialog preferences_dialog;
6
7 private Gtk.Dialog dialog;
8- private Gtk.HeaderBar header;
9 private Gtk.Builder builder;
10 private Gtk.FileChooserButton library_dir_button;
11 private Gtk.ComboBoxText dir_pattern_combo;
12@@ -2093,16 +2092,10 @@
13 dialog.width_request = 450;
14 dialog.type_hint = Gdk.WindowTypeHint.DIALOG;
15 dialog.resizable = false;
16+ dialog.deletable = false;
17 dialog.delete_event.connect (on_delete);
18 dialog.map_event.connect (map_event_handler);
19 dialog.set_parent_window (AppWindow.get_instance ().get_parent_window ());
20-
21- header = new Gtk.HeaderBar ();
22- header.show_close_button = false;
23- header.title = _("Preferences");
24- header.get_style_context ().remove_class ("header-bar");
25-
26- dialog.set_titlebar (header);
27
28 // Create our stack container and load in each preference container from shotwell.glade
29 Gtk.Stack container = new Gtk.Stack ();
30@@ -2330,7 +2323,6 @@
31 }
32
33 private void set_allow_closing (bool allow) {
34- dialog.set_deletable (allow);
35 close_button.set_sensitive (allow);
36 allow_closing = allow;
37 }
38@@ -2448,4 +2440,4 @@
39 progress.close ();
40
41 AppWindow.get_instance ().set_normal_cursor ();
42-}
43\ No newline at end of file
44+}

Subscribers

People subscribed via source and target branches