Noise

Merge lp:~fabiozaramella/noise/fix-for-1278191 into lp:~elementary-apps/noise/trunk

  1. fix-for-1278191
  2. Merge into trunk
Proposed by Fabio Zaramella
Status: Merged
Approved by: Corentin Noël
Approved revision: 1608
Merged at revision: 1630
Proposed branch: lp:~fabiozaramella/noise/fix-for-1278191
Merge into: lp:~elementary-apps/noise/trunk
Diff against target: 11 lines (+1/-1)
1 file modified
src/Widgets/StatusBar.vala (+1/-1)
To merge this branch: bzr merge lp:~fabiozaramella/noise/fix-for-1278191
Reviewer Review Type Date Requested Status
Corentin Noël Approve
Victor Martinez (community) Approve
Review via email: mp+223624@code.launchpad.net

This proposal supersedes a proposal from 2014-06-01.

Commit message

"Repeat All" string changed to "Disable Repeat".

To post a comment you must log in.
Revision history for this message
Victor Martinez (victored) wrote : Posted in a previous version of this proposal

Looks good to me.

review: Approve
Revision history for this message
Victor Martinez (victored) :
review: Approve
Revision history for this message
Corentin Noël (tintou) wrote :

There is a difference between repeat all and disable repeat :
 * Repeat all: starts the first song of a list when the last song is reached
 * Disable repeat: ends playback when the last song is reached

review: Disapprove
Revision history for this message
Corentin Noël (tintou) wrote :

Oops, I misreaded the branch

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/StatusBar.vala'
2--- src/Widgets/StatusBar.vala 2014-04-19 21:51:46 +0000
3+++ src/Widgets/StatusBar.vala 2014-06-18 17:48:28 +0000
4@@ -69,7 +69,7 @@
5 appendItem (_("Song"), repeat_one_image, _("Repeat Song"));
6 appendItem (_("Album"), repeat_on_image, _("Repeat Album"));
7 appendItem (_("Artist"), repeat_on_image, _("Repeat Artist"));
8- appendItem (_("All"), repeat_on_image, _("Repeat All"));
9+ appendItem (_("All"), repeat_on_image, _("Disable Repeat"));
10
11 update_option ();
12

Subscribers

People subscribed via source and target branches