Merge lp:~fabianthoma/wingpanel/dconf-fixes-bug949303 into lp:~elementary-pantheon/wingpanel/old-trunk

Proposed by Fabian Thoma
Status: Merged
Merged at revision: 60
Proposed branch: lp:~fabianthoma/wingpanel/dconf-fixes-bug949303
Merge into: lp:~elementary-pantheon/wingpanel/old-trunk
Diff against target: 140 lines (+39/-24)
5 files modified
org.elementary.wingpanel.gschema.xml (+10/-5)
src/Services/IndicatorFileModel.vala (+5/-1)
src/Settings.vala (+3/-1)
src/Widgets/Panel.vala (+7/-5)
src/WingpanelApp.vala (+14/-12)
To merge this branch: bzr merge lp:~fabianthoma/wingpanel/dconf-fixes-bug949303
Reviewer Review Type Date Requested Status
Fabian Thoma Approve
Review via email: mp+104161@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Fabian Thoma (fabianthoma) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'org.elementary.wingpanel.gschema.xml'
2--- org.elementary.wingpanel.gschema.xml 2011-11-02 22:37:51 +0000
3+++ org.elementary.wingpanel.gschema.xml 2012-04-30 18:28:18 +0000
4@@ -5,10 +5,15 @@
5 <summary>List of indicators.</summary>
6 <description>These indicators will not be displayed in Wingpanel.</description>
7 </key>
8- <key type="s" name="default-launcher">
9- <default>"slingshot"</default>
10- <summary>The default program to use as App launcher.</summary>
11- <description>Description</description>
12- </key>
13+ <key type="b" name="show-launcher">
14+ <default>true</default>
15+ <summary>Wheather to show the Applications Launcher or not.</summary>
16+ <description>Wheather to show the Applications Launcher or not.</description>
17+ </key>
18+ <key type="s" name="default-launcher">
19+ <default>"slingshot"</default>
20+ <summary>The default program to use as App launcher.</summary>
21+ <description>Description</description>
22+ </key>
23 </schema>
24 </schemalist>
25
26=== modified file 'src/Services/IndicatorFileModel.vala'
27--- src/Services/IndicatorFileModel.vala 2012-01-30 18:27:57 +0000
28+++ src/Services/IndicatorFileModel.vala 2012-04-30 18:28:18 +0000
29@@ -81,7 +81,11 @@
30 }
31
32 /* Don't load appmenu-gtk */
33- skip_list += ",libappmenu.so";
34+ foreach(string blocked_indicator in Wingpanel.app.settings.blacklist) {
35+ skip_list += "," + blocked_indicator;
36+ log("wingpanel", LogLevelFlags.LEVEL_DEBUG, "Blacklisting %s", blocked_indicator);
37+ }
38+ log("wingpanel", LogLevelFlags.LEVEL_DEBUG, "Blacklisted Indicators: %s", skip_list);
39
40 /* We need to look for icons in an specific location */
41 //Gtk.IconTheme.get_default ().append_search_path (Wingpanel.Config.INDICATORICONSDIR);
42
43=== modified file 'src/Settings.vala'
44--- src/Settings.vala 2012-01-30 18:27:57 +0000
45+++ src/Settings.vala 2012-04-30 18:28:18 +0000
46@@ -22,8 +22,10 @@
47
48 public class Settings : Granite.Services.Settings {
49
50+ public string[] blacklist { get; set; }
51+ public bool show_launcher { get; set; }
52 public string default_launcher { get; set; }
53-
54+
55 public Settings () {
56 base ("desktop.pantheon.wingpanel");
57 }
58
59=== modified file 'src/Widgets/Panel.vala'
60--- src/Widgets/Panel.vala 2012-02-04 23:04:33 +0000
61+++ src/Widgets/Panel.vala 2012-04-30 18:28:18 +0000
62@@ -24,7 +24,7 @@
63 using Granite.Services;
64
65 namespace Wingpanel {
66-
67+
68 public enum Struts {
69 LEFT,
70 RIGHT,
71@@ -230,11 +230,13 @@
72
73 private void add_defaults () {
74
75- // Apps button
76- var apps = new Widgets.AppsButton ();
77- apps.button_press_event.connect (launch_launcher);
78+ // Only show Apps button if enabled in the settings
79+ if(this.app.settings.show_launcher) {
80+ var apps = new Widgets.AppsButton ();
81+ apps.button_press_event.connect (launch_launcher);
82
83- left_wrapper.pack_start (apps, false, true, 0);
84+ left_wrapper.pack_start (apps, false, true, 0);
85+ }
86 container.pack_start (left_wrapper);
87
88 clock = new Gtk.MenuBar ();
89
90=== modified file 'src/WingpanelApp.vala'
91--- src/WingpanelApp.vala 2012-01-30 18:27:57 +0000
92+++ src/WingpanelApp.vala 2012-04-30 18:28:18 +0000
93@@ -21,6 +21,8 @@
94
95 namespace Wingpanel {
96
97+ public WingpanelApp app;
98+
99 public class WingpanelApp : Granite.Application {
100
101 private Panel panel = null;
102@@ -37,18 +39,18 @@
103 build_version_info = Build.VERSION_INFO;
104
105 program_name = "Wingpanel";
106- exec_name = "wingpanel";
107- app_copyright = "GPLv3";
108- app_icon = "";
109- app_launcher = "";
110+ exec_name = "wingpanel";
111+ app_copyright = "GPLv3";
112+ app_icon = "";
113+ app_launcher = "";
114 application_id = "net.launchpad.wingpanel";
115- main_url = "https://launchpad.net/wingpanel";
116- bug_url = "https://bugs.launchpad.net/wingpanel";
117- help_url = "https://answers.launchpad.net/wingpanel";
118- translate_url = "https://translations.launchpad.net/wingpanel";
119+ main_url = "https://launchpad.net/wingpanel";
120+ bug_url = "https://bugs.launchpad.net/wingpanel";
121+ help_url = "https://answers.launchpad.net/wingpanel";
122+ translate_url = "https://translations.launchpad.net/wingpanel";
123
124- about_authors = {"Giulio Collura <random.cpp@gmail.com>"};
125- about_artists = {"Daniel Foré <bunny@go-docky.com>"};
126+ about_authors = {"Giulio Collura <random.cpp@gmail.com>"};
127+ about_artists = {"Daniel Foré <bunny@go-docky.com>"};
128
129 }
130
131@@ -83,8 +85,8 @@
132 }
133
134 public static int main (string[] args) {
135-
136- return new WingpanelApp ().run (args);
137+ Wingpanel.app = new WingpanelApp ();
138+ return Wingpanel.app.run (args);
139
140 }
141

Subscribers

People subscribed via source and target branches

to all changes: