Merge lp:~f-thiessen/kicad/install-script-update into lp:kicad/product

Proposed by Ferdinand T.
Status: Rejected
Rejected by: Chris Pavlina
Proposed branch: lp:~f-thiessen/kicad/install-script-update
Merge into: lp:kicad/product
Diff against target: 67 lines (+39/-2)
1 file modified
scripts/kicad-install.sh (+39/-2)
To merge this branch: bzr merge lp:~f-thiessen/kicad/install-script-update
Reviewer Review Type Date Requested Status
KiCad Lead Developers Pending
Review via email: mp+256610@code.launchpad.net

Description of the change

Added support for openSUSE (pm is zypper) for the kicad installation script.

To post a comment you must log in.
Revision history for this message
Miguel Angel Ajo (mangelajo) wrote :
Download full text (3.2 KiB)

Hi Ferdinand,

  I believe the plan forward is to remove the kicad-install.sh from the repository,
since we are getting into a better position to offer built binaries for every platform
(nightly and stable).

Best,
Miguel Ángel.

> On 17/4/2015, at 2:23, Ferdinand T. <email address hidden> wrote:
>
> Ferdinand T. has proposed merging lp:~f-thiessen/kicad/install-script-update into lp:kicad.
>
> Requested reviews:
> kicad-product-committers (kicad-product-committers)
>
> For more details, see:
> https://code.launchpad.net/~f-thiessen/kicad/install-script-update/+merge/256610
>
> Added support for openSUSE (pm is zypper) for the kicad installation script.
> --
> You are subscribed to branch lp:kicad.
> === modified file 'scripts/kicad-install.sh'
> --- scripts/kicad-install.sh 2015-03-30 21:29:04 +0000
> +++ scripts/kicad-install.sh 2015-04-17 00:22:33 +0000
> @@ -2,6 +2,7 @@
> # Install KiCad from source onto either:
> # -> a Ubuntu/Debian/Mint or
> # -> a Red Hat
> +# -> a openSUSE
> # compatible linux system.
> #
> # The "install_prerequisites" step is the only "distro dependent" one. That step could be modified
> @@ -95,7 +96,7 @@
> install_prerequisites()
> {
> # Find a package manager, PM
> - PM=$( command -v yum || command -v apt-get )
> + PM=$( command -v yum || command -v apt-get || command -v zypper )
>
> # assume all these Debian, Mint, Ubuntu systems have same prerequisites
> if [ "$(expr match "$PM" '.*\(apt-get\)')" == "apt-get" ]; then
> @@ -184,9 +185,45 @@
> sudo yum install $sp || exit 1
> done
> fi
> + # assume all zypper systems like openSUSE have same prerequisites
> + elif [ "$(expr match "$PM" '.*\(zypper\)')" == "zypper" ]; then
> + #echo "slackware / openSUSE compatible system"
> + # openSUSE does not have bzrtools in standard repositories, so look at http://software.opensuse.org/package/bzrtools?search_term=bzrtools
> + # Note: if you find this list not to be accurate, please submit a patch:
> + prerequisite_list="
> + bzr
> + libzip2
> + libbz2-devel
> + cmake
> + cmake-gui
> + doxygen
> + cairo-devel
> + glew-devel
> + grep
> + libopenssl-devel
> + wxWidgets-3_0-devel
> + "
> +
> + for p in ${prerequisite_list}
> + do
> + sudo zypper in $p || exit 1
> + done
> +
> + # Only install the scripting prerequisites if required.
> + if [ "$(expr match "$OPTS" '.*\(-DKICAD_SCRIPTING=ON\)')" == "-DKICAD_SCRIPTING=ON" ]; then
> + #echo "KICAD_SCRIPTING=ON"
> + scripting_prerequisites="
> + python-wxWidgets
> + "
> +
> + for sp in ${scripting_prerequisites}
> + do
> + sudo zypper in $sp || exit 1
> + done
> + fi
> else
> echo
> - echo "Incompatible System. Neither 'yum' nor 'apt-get' found. Not possible to continue."
> + echo "Incompatible System. Neither 'yum' nor 'apt-get' nor 'zypper' found. Not possible to continue."
> ech...

Read more...

Revision history for this message
Chris Pavlina (pavlina-chris) wrote :

Indeed, kicad-install.sh is deprecated and will be removed.

Unmerged revisions

5605. By Ferdinand T.

Slightly modified install script (see also last commit).

5604. By Ferdinand T.

Added zypper support (e.g. openSUSE) for kicad install script.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/kicad-install.sh'
2--- scripts/kicad-install.sh 2015-03-30 21:29:04 +0000
3+++ scripts/kicad-install.sh 2015-04-17 00:22:33 +0000
4@@ -2,6 +2,7 @@
5 # Install KiCad from source onto either:
6 # -> a Ubuntu/Debian/Mint or
7 # -> a Red Hat
8+# -> a openSUSE
9 # compatible linux system.
10 #
11 # The "install_prerequisites" step is the only "distro dependent" one. That step could be modified
12@@ -95,7 +96,7 @@
13 install_prerequisites()
14 {
15 # Find a package manager, PM
16- PM=$( command -v yum || command -v apt-get )
17+ PM=$( command -v yum || command -v apt-get || command -v zypper )
18
19 # assume all these Debian, Mint, Ubuntu systems have same prerequisites
20 if [ "$(expr match "$PM" '.*\(apt-get\)')" == "apt-get" ]; then
21@@ -184,9 +185,45 @@
22 sudo yum install $sp || exit 1
23 done
24 fi
25+ # assume all zypper systems like openSUSE have same prerequisites
26+ elif [ "$(expr match "$PM" '.*\(zypper\)')" == "zypper" ]; then
27+ #echo "slackware / openSUSE compatible system"
28+ # openSUSE does not have bzrtools in standard repositories, so look at http://software.opensuse.org/package/bzrtools?search_term=bzrtools
29+ # Note: if you find this list not to be accurate, please submit a patch:
30+ prerequisite_list="
31+ bzr
32+ libzip2
33+ libbz2-devel
34+ cmake
35+ cmake-gui
36+ doxygen
37+ cairo-devel
38+ glew-devel
39+ grep
40+ libopenssl-devel
41+ wxWidgets-3_0-devel
42+ "
43+
44+ for p in ${prerequisite_list}
45+ do
46+ sudo zypper in $p || exit 1
47+ done
48+
49+ # Only install the scripting prerequisites if required.
50+ if [ "$(expr match "$OPTS" '.*\(-DKICAD_SCRIPTING=ON\)')" == "-DKICAD_SCRIPTING=ON" ]; then
51+ #echo "KICAD_SCRIPTING=ON"
52+ scripting_prerequisites="
53+ python-wxWidgets
54+ "
55+
56+ for sp in ${scripting_prerequisites}
57+ do
58+ sudo zypper in $sp || exit 1
59+ done
60+ fi
61 else
62 echo
63- echo "Incompatible System. Neither 'yum' nor 'apt-get' found. Not possible to continue."
64+ echo "Incompatible System. Neither 'yum' nor 'apt-get' nor 'zypper' found. Not possible to continue."
65 echo
66 exit 1
67 fi