Merge lp:~f-kalsbeek/openobject-client-web/mindswitch into lp:openobject-client-web/trunk

Proposed by Freerk Kalsbeek (Mindswitch BV)
Status: Rejected
Rejected by: Amit Mendapara
Proposed branch: lp:~f-kalsbeek/openobject-client-web/mindswitch
Merge into: lp:openobject-client-web/trunk
Diff against target: None lines
To merge this branch: bzr merge lp:~f-kalsbeek/openobject-client-web/mindswitch
Reviewer Review Type Date Requested Status
OpenERP Committers Pending
Review via email: mp+5169@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Fabien (Open ERP) (fp-tinyerp) wrote :

Amit, I propose that you give a small explanation when you reject a
merge proposal.

ame (Tiny/Axelor) wrote:
> The proposal to merge lp:~f-kalsbeek/openobject-client-web/mindswitch into lp:openobject-client-web has been updated.
>
> Status: Needs review => Rejected

--
Fabien Pinckaers
CEO Tiny - OpenERP Editor
Chaussée de Namur 40
B-1367 Grand-Rosière
Belgium
Phone: +32.81.81.37.00
Fax: +32.81.73.35.01
Web: http://openerp.com

Great Achievements Start With Tiny Investments
   -- Marty, 2005

Revision history for this message
Amit Mendapara (cristatus) wrote :

Fabien (Open ERP) wrote:
> Amit, I propose that you give a small explanation when you reject a
> merge proposal.
>
> ame (Tiny/Axelor) wrote:
>> The proposal to merge lp:~f-kalsbeek/openobject-client-web/mindswitch into lp:openobject-client-web has been updated.
>>
>> Status: Needs review => Rejected
>
>

The proposed feature has already been implemented. Please see the
README.txt section 5.

Unmerged revisions

2342. By Freerk Kalsbeek (Mindswitch BV)

Merged Trunk

2341. By Freerk Kalsbeek (Mindswitch BV)

HTTPS Filter added for proxying webclient by Apache SSL

2340. By Freerk Kalsbeek (Mindswitch BV)

Added HTTPSFilter, so redirects are sent to the https URL instead of
HTTP when proxied by apache
To activate:
1. put the following in your .cfg
   https_filter.on = True

2. Put the following in your Apache VirtualHost config
   RequestHeader add X-Requested-Ssl "Yes"

mod_headers must be active for apache. To activate use a2enmod headers

2339. By Freerk Kalsbeek (Mindswitch BV)

Implemented a feature that allows to select a database based on the
exact hostname used in the proxy request. Eg. sample.domain.com lists
only database 'sample' where sample1.domain.com will only list 'sample1'
This feature is activated through the new config value
dblist.filter.exact. If set to True, the function will work. Requires
dblist.filter to be set to True as well.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/controllers.py'
2--- openerp/controllers.py 2009-03-27 08:38:21 +0000
3+++ openerp/controllers.py 2009-04-02 18:29:47 +0000
4@@ -53,6 +53,8 @@
5 from openerp.tinyres import TinyResource, unsecured
6 from openerp.tinyres import login as tiny_login
7
8+from openerp.httpsfilter import HTTPSFilter
9+
10 import pkg_resources
11 from turbogears.widgets import register_static_directory
12
13@@ -71,6 +73,8 @@
14 """Turbogears root controller, see TG docs for more info.
15 """
16
17+ _cp_filters = [HTTPSFilter()]
18+
19 def user_action(self, id='action_id'):
20 """Perform default user action.
21
22
23=== added file 'openerp/httpsfilter.py'
24--- openerp/httpsfilter.py 1970-01-01 00:00:00 +0000
25+++ openerp/httpsfilter.py 2009-04-02 06:45:51 +0000
26@@ -0,0 +1,24 @@
27+from cherrypy.filters.basefilter import BaseFilter
28+import cherrypy
29+from turbogears import config
30+
31+class HTTPSFilter(BaseFilter):
32+
33+ def before_request_body(self):
34+ # if the filter isn't turned on, exit immediately
35+ if not config.get('https_filter.on', False):
36+ return
37+
38+ request = cherrypy.request
39+
40+ # Check for a special header 'X-Requested-Ssl'. If we have it,
41+ # then we substitute the secure base url
42+ requested_ssl = request.headers.get('X-Requested-Ssl', 'NO').upper()
43+ if requested_ssl == 'YES':
44+ base = config.get('https_filter.secure_base_url', None)
45+ if base == None:
46+ if config.get('base_url_filter.use_x_forwarded_host', False):
47+ base = request.headers.get('X-Forwarded-Host', 'localhost')
48+ else:
49+ base = 'localhost'
50+ request.base = 'https://' + base
51
52=== modified file 'openerp/tinyres.py'
53--- openerp/tinyres.py 2009-03-12 18:00:36 +0000
54+++ openerp/tinyres.py 2009-03-29 22:23:26 +0000
55@@ -60,8 +60,11 @@
56 host = headers.get('X-Forwarded-Host', headers.get('Host'))
57
58 base = re.split('\.|:|/', host)[0]
59- base = base + '_'
60- dblist = [d for d in dblist if d.startswith(base)]
61+ if config.get('dblist.filter.exact', path='openerp-web'):
62+ dblist = [d for d in dblist if d == base]
63+ else:
64+ base = base + '_'
65+ dblist = [d for d in dblist if d.startswith(base)]
66
67 return dict(target=target, url=url, dblist=dblist, db=db, user=user, password=password,
68 action=action, message=message, origArgs=origArgs)
69
70=== modified file 'openerp_web.egg-info/SOURCES.txt'
71--- openerp_web.egg-info/SOURCES.txt 2009-03-19 06:54:04 +0000
72+++ openerp_web.egg-info/SOURCES.txt 2009-04-02 18:29:47 +0000
73@@ -33,8 +33,6 @@
74 openerp/config/log.cfg
75 openerp/static/open-flash-chart.swf
76 openerp/static/css/dashboard.css
77-openerp/static/css/iepngfix.css
78-openerp/static/css/iepngfix.htc
79 openerp/static/css/listgrid.css
80 openerp/static/css/menu.css
81 openerp/static/css/modalbox.css
82@@ -705,6 +703,7 @@
83 openerp/templates/__init__.py
84 openerp/templates/about.kid
85 openerp/templates/login.kid
86+openerp/templates/login_ajax.kid
87 openerp/templates/master.kid
88 openerp/tests/__init__.py
89 openerp/tests/test_controllers.py
90@@ -790,4 +789,4 @@
91 openerp_web.egg-info/requires.txt
92 openerp_web.egg-info/sqlobject.txt
93 openerp_web.egg-info/top_level.txt
94-scripts/openerp-web
95+scripts/openerp-web
96\ No newline at end of file