Odoo Addons (MOVED TO GITHUB)

Merge lp:~eyssen/openobject-addons/extra-bug-819698-etl_component_row_count into lp:openobject-addons/extra-6.0

  1. extra-bug-819698-etl_component_row_count
  2. Merge into extra-6.0
Proposed by Krisztian Eyssen
Status: Merged
Merged at revision: 5491
Proposed branch: lp:~eyssen/openobject-addons/extra-bug-819698-etl_component_row_count
Merge into: lp:openobject-addons/extra-6.0
Diff against target: 12 lines (+1/-1)
1 file modified
etl/lib/etl/component/component.py (+1/-1)
To merge this branch: bzr merge lp:~eyssen/openobject-addons/extra-bug-819698-etl_component_row_count
Reviewer Review Type Date Requested Status
Rucha (Open ERP) Approve
Krisztian Eyssen (community) Approve
Mustufa Rangwala (Open ERP) Pending
Atik Agewan(OpenERP) Pending
OpenERP Committers Pending
OpenERP Community Committers Pending
Review via email: mp+70146@code.launchpad.net

Description of the change

In the etl module component.py file the row_count param doesn't exist, replaced to self.row_count, one param not changed "row_count" to "self.row_count"

To post a comment you must log in.
Revision history for this message
Krisztian Eyssen (eyssen) :
review: Approve
Revision history for this message
Rucha (Open ERP) (rpa-openerp) wrote :

Thanks for you contribution, it seems perfect!

review: Approve
Revision history for this message
Krisztian Eyssen (eyssen) wrote :

Hi

When does it merge with the extra-6.0 branch ?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'etl/lib/etl/component/component.py'
2--- etl/lib/etl/component/component.py 2010-07-10 07:23:16 +0000
3+++ etl/lib/etl/component/component.py 2011-08-02 11:39:31 +0000
4@@ -170,7 +170,7 @@
5 data, chan = gen.next()
6 # row_count += 1
7 self.row_count += 1
8- if self.row_limit and row_count > self.row_limit:
9+ if self.row_limit and self.row_count > self.row_limit:
10 raise StopIteration
11 if data is None:
12 self.signal('no_input')