Merge lp:~extra-addons-commiter/e-commerce-addons/7.0-sale-workflow-create_invoice_on into lp:~extra-addons-commiter/e-commerce-addons/7.0
Status: | Work in progress |
---|---|
Proposed branch: | lp:~extra-addons-commiter/e-commerce-addons/7.0-sale-workflow-create_invoice_on |
Merge into: | lp:~extra-addons-commiter/e-commerce-addons/7.0 |
Prerequisite: | lp:~extra-addons-commiter/e-commerce-addons/7.0-sale-workflow |
Diff against target: |
150 lines (+55/-24) 5 files modified
sale_automatic_workflow/automatic_workflow_data.xml (+17/-7) sale_automatic_workflow/sale.py (+16/-0) sale_automatic_workflow/sale_workflow.xml (+1/-1) sale_automatic_workflow/sale_workflow_process.py (+19/-14) sale_automatic_workflow/sale_workflow_process_view.xml (+2/-2) |
To merge this branch: | bzr merge lp:~extra-addons-commiter/e-commerce-addons/7.0-sale-workflow-create_invoice_on |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sébastien BEAU - http://www.akretion.com | Needs Information | ||
Review via email: mp+159321@code.launchpad.net |
Commit message
[IMP] the option to create an invoice now allows to choose if it is created on the confirmation of the sale order or after the delivery
Description of the change
Since the postpaid invoice policy has been removed from OpenERP 7.0 (lp:1160835), I had to remove it from the automatic workflows.
In order to emulate it, I replace the boolean option 'create_invoice' by a selection of values allowing to choose if the invoice is:
- not created automatically
- created on the confirmation of the sale order
- created after the delivery
This is efficient only if the invoice policy is 'On Demand', so i also set the field to readonly when an other policy is selected (it was the case before but the checkbox was not deactivated).
Unmerged revisions
- 305. By Guewen Baconnier @ Camptocamp
-
[FIX] do not activate force invoice date in the base workflows
- 304. By Guewen Baconnier @ Camptocamp
-
[FIX] updated base data according to last change and addded a manual workflow
- 303. By Guewen Baconnier @ Camptocamp
-
[IMP] the option to create an invoice now allows to choose if it is created on the confirmation of the sale order or after the delivery
Great job Guewen, I just read the code and I have some comment date_is_ order_date" is a good idea. It's usefull for importing an historic but in day to day you will have invoice number than will not match with the invoice date.
Regarding the default value for the workflow method before it was 'creating invoice after delivery' now it's manual, maybe it' will be better to keep the same behaviour? And setting invoice => 'after delivery' instead of "manual".
also I am not sure that activating by default the option "invoice_
What do you think?