Merge lp:~exarkun/divmod.org/spambayes-hammie-args into lp:divmod.org

Proposed by Jean-Paul Calderone
Status: Merged
Approved by: Tristan Seligmann
Approved revision: 2696
Merged at revision: 2696
Proposed branch: lp:~exarkun/divmod.org/spambayes-hammie-args
Merge into: lp:divmod.org
Diff against target: 21 lines (+2/-2)
1 file modified
Quotient/xquotient/spam.py (+2/-2)
To merge this branch: bzr merge lp:~exarkun/divmod.org/spambayes-hammie-args
Reviewer Review Type Date Requested Status
Tristan Seligmann Approve
Review via email: mp+117268@code.launchpad.net

Description of the change

Pass new required `mode` argument to spambayes.hammie.Hammie initializer. Makes existing unit tests pass again. Backwards incompatible with older versions of spambayes.

To post a comment you must log in.
Revision history for this message
Tristan Seligmann (mithrandi) wrote :

I guess if any other Quotient users (ha ha) want to use an older spambayes, they can contribute code to suppport both old and new simultaneously.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Quotient/xquotient/spam.py'
2--- Quotient/xquotient/spam.py 2009-07-16 00:52:55 +0000
3+++ Quotient/xquotient/spam.py 2012-07-30 13:34:20 +0000
4@@ -393,7 +393,7 @@
5 log.err()
6 c = classifier.Classifier()
7 self.classifier = c
8- self.guesser = hammie.Hammie(c)
9+ self.guesser = hammie.Hammie(c, mode='r')
10
11
12 # IHamFilter
13@@ -432,7 +432,7 @@
14 if p.exists():
15 p.remove()
16 self.classifier = classifier.Classifier()
17- self.guesser = hammie.Hammie(self.classifier)
18+ self.guesser = hammie.Hammie(self.classifier, mode='r')
19
20
21 item.declareLegacyItem(SpambayesFilter.typeName, 1, dict(

Subscribers

People subscribed via source and target branches