Merge lp:~exarkun/divmod.org/spambayes-fewer-potatoes into lp:divmod.org
Proposed by
Jean-Paul Calderone
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Tristan Seligmann | ||||
Approved revision: | 2713 | ||||
Merged at revision: | 2698 | ||||
Proposed branch: | lp:~exarkun/divmod.org/spambayes-fewer-potatoes | ||||
Merge into: | lp:divmod.org | ||||
Diff against target: |
327 lines (+222/-14) 3 files modified
Quotient/benchmarks/spambayes (+44/-0) Quotient/xquotient/spam.py (+91/-14) Quotient/xquotient/test/test_spambayes.py (+87/-0) |
||||
To merge this branch: | bzr merge lp:~exarkun/divmod.org/spambayes-fewer-potatoes | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tristan Seligmann | Approve | ||
Review via email: mp+121094@code.launchpad.net |
Description of the change
Some speedups to the new spambayes database layer. Benchmark results on the ticket (sorry, Launchpad, how do you work exactly?)
To post a comment you must log in.
Looking at this, it occurs to me that it would be nice if Axiom had an intermediate SQL-construction layer that is usable without the full ORM. Then again, maybe that's just called "Storm", and it's certainly out of scope for this branch ;)
The code looks reasonably good to me, the extensive docstrings even better; please merge.