Merge lp:~exarkun/divmod.org/pop3-timeouts into lp:divmod.org
Proposed by
Jean-Paul Calderone
Status: | Merged |
---|---|
Approved by: | Tristan Seligmann |
Approved revision: | 2695 |
Merged at revision: | 2693 |
Proposed branch: | lp:~exarkun/divmod.org/pop3-timeouts |
Merge into: | lp:divmod.org |
Diff against target: |
144 lines (+75/-18) 2 files modified
Quotient/xquotient/grabber.py (+5/-3) Quotient/xquotient/test/test_grabber.py (+70/-15) |
To merge this branch: | bzr merge lp:~exarkun/divmod.org/pop3-timeouts |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tristan Seligmann | Approve | ||
Review via email: mp+105489@code.launchpad.net |
Description of the change
Branch does a couple things:
- Adds a check to `setStatus` to not bother doing anything if `grabber` has already been discarded
- Shuffles things around a bit in `timeoutConnection` so the timeout is actually reflected in the status.
To post a comment you must log in.
I haven't actually tested the code, but the diff looks reasonable.