Merge lp:~ewanmellor/nova/lp835964 into lp:~hudson-openstack/nova/trunk

Proposed by Ewan Mellor
Status: Merged
Approved by: Vish Ishaya
Approved revision: 1500
Merged at revision: 1503
Proposed branch: lp:~ewanmellor/nova/lp835964
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 25 lines (+3/-2)
2 files modified
nova/ipv6/account_identifier.py (+2/-1)
nova/tests/test_ipv6.py (+1/-1)
To merge this branch: bzr merge lp:~ewanmellor/nova/lp835964
Reviewer Review Type Date Requested Status
Vish Ishaya (community) Approve
Brian Lamar (community) Approve
Review via email: mp+73174@code.launchpad.net

Commit message

Bug #835964: pep8 violations in IPv6 code

Fix pep8 violations.

Description of the change

Bug #835964: pep8 violations in IPv6 code

Fix pep8 violations.

To post a comment you must log in.
Revision history for this message
Brian Lamar (blamar) :
review: Approve
Revision history for this message
Vish Ishaya (vishvananda) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nova/ipv6/account_identifier.py'
2--- nova/ipv6/account_identifier.py 2011-08-22 01:01:34 +0000
3+++ nova/ipv6/account_identifier.py 2011-08-28 10:51:40 +0000
4@@ -39,7 +39,8 @@
5 except TypeError:
6 raise TypeError(_('Bad prefix for to_global_ipv6: %s') % prefix)
7 except NameError:
8- raise TypeError(_('Bad project_id for to_global_ipv6: %s') % project_id)
9+ raise TypeError(_('Bad project_id for to_global_ipv6: %s') %
10+ project_id)
11
12
13 def to_mac(ipv6_address):
14
15=== modified file 'nova/tests/test_ipv6.py'
16--- nova/tests/test_ipv6.py 2011-08-24 16:01:48 +0000
17+++ nova/tests/test_ipv6.py 2011-08-28 10:51:40 +0000
18@@ -48,7 +48,7 @@
19 def test_to_global_with_bad_prefix(self):
20 bad_prefix = '82'
21 self.assertRaises(TypeError, ipv6.to_global,
22- bad_prefix,
23+ bad_prefix,
24 '2001:db8::216:3eff:fe33:4455',
25 'test')
26