Merge lp:~evgeni/libindicator/multiarch-same-devheaders into lp:libindicator/12.10

Proposed by Evgeni Golov
Status: Merged
Approved by: Charles Kerr
Approved revision: 468
Merged at revision: 468
Proposed branch: lp:~evgeni/libindicator/multiarch-same-devheaders
Merge into: lp:libindicator/12.10
Diff against target: 27 lines (+3/-3)
2 files modified
libindicator/indicator-object-enum-types.c.template (+2/-2)
libindicator/indicator-object-enum-types.h.template (+1/-1)
To merge this branch: bzr merge lp:~evgeni/libindicator/multiarch-same-devheaders
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+109516@code.launchpad.net

Description of the change

don't include build-time filenames in comments of the enum header files

If we do, the header files may be different on each build.
This is especially harmful when building multiple times for multiple
architectures and expecting the files to be identical.

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

I wouldn't've thought of that.

Nice catch. :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libindicator/indicator-object-enum-types.c.template'
2--- libindicator/indicator-object-enum-types.c.template 2010-03-16 16:40:14 +0000
3+++ libindicator/indicator-object-enum-types.c.template 2012-06-10 09:22:22 +0000
4@@ -3,8 +3,8 @@
5 /*** END file-header ***/
6
7 /*** BEGIN file-production ***/
8-/* enumerations from "@filename@" */
9-#include "@filename@"
10+/* enumerations from "@basename@" */
11+#include "@basename@"
12 /*** END file-production ***/
13
14 /*** BEGIN value-header ***/
15
16=== modified file 'libindicator/indicator-object-enum-types.h.template'
17--- libindicator/indicator-object-enum-types.h.template 2010-03-16 16:40:14 +0000
18+++ libindicator/indicator-object-enum-types.h.template 2012-06-10 09:22:22 +0000
19@@ -10,7 +10,7 @@
20 /*** END file-header ***/
21
22 /*** BEGIN file-production ***/
23-/* enumerations from "@filename@" */
24+/* enumerations from "@basename@" */
25 /*** END file-production ***/
26
27 /*** BEGIN file-tail ***/

Subscribers

People subscribed via source and target branches