Merge lp:~evfool/update-manager/handlewarning into lp:update-manager

Proposed by Robert Roth
Status: Merged
Merged at revision: 2225
Proposed branch: lp:~evfool/update-manager/handlewarning
Merge into: lp:update-manager
Diff against target: 13 lines (+2/-1)
1 file modified
UpdateManager/UpdateManager.py (+2/-1)
To merge this branch: bzr merge lp:~evfool/update-manager/handlewarning
Reviewer Review Type Date Requested Status
Michael Vogt Pending
Review via email: mp+74160@code.launchpad.net

Description of the change

This branch eliminates a warning when changing the selected packages quickly. In this case the downloads start for each packages changelog ad when they are finished the handler should get disconnected, but because we have changed the selected package, we get a warning in the console about the handler not being connected. So before disconnecting a handler, I have added a check to see if it's still connected. Fixes bug #133139.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'UpdateManager/UpdateManager.py'
2--- UpdateManager/UpdateManager.py 2011-08-19 10:14:50 +0000
3+++ UpdateManager/UpdateManager.py 2011-09-06 05:18:24 +0000
4@@ -465,7 +465,8 @@
5 Gtk.main_iteration()
6 # download finished (or canceld, or time-out)
7 button.hide()
8- button.disconnect(id);
9+ if button.handler_is_connected(id):
10+ button.disconnect(id)
11 # check if we still are in the right pkg (the download may have taken
12 # some time and the user may have clicked on a new pkg)
13 path = widget.get_cursor()[0]

Subscribers

People subscribed via source and target branches

to status/vote changes: