Software Updater

Merge lp:~evfool/update-manager/fixdefaults into lp:update-manager

  1. fixdefaults
  2. Merge into main
Proposed by Robert Roth
Status: Merged
Merged at revision: 2121
Proposed branch: lp:~evfool/update-manager/fixdefaults
Merge into: lp:update-manager
Diff against target: 50 lines (+5/-7)
1 file modified
data/glade/UpdateManager.ui (+5/-7)
To merge this branch: bzr merge lp:~evfool/update-manager/fixdefaults
Reviewer Review Type Date Requested Status
Michael Terry Approve
Review via email: mp+61422@code.launchpad.net

Description of the change

Fix for bug #422673 and bug #628186 , allowing buttons (Settings, Close, Check, Install updates, Upgrade) to receive default to execute their action on pressing Enter instead of closing the interface, as currently only Close is set to receive the Enter keypress, thus pressing Enter anywhere will close the interface.

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

Looks good, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/glade/UpdateManager.ui'
2--- data/glade/UpdateManager.ui 2011-03-29 17:16:47 +0000
3+++ data/glade/UpdateManager.ui 2011-05-18 14:59:23 +0000
4@@ -878,7 +878,7 @@
5 <property name="label" translatable="yes">U_pgrade</property>
6 <property name="visible">True</property>
7 <property name="can_focus">True</property>
8- <property name="receives_default">False</property>
9+ <property name="receives_default">True</property>
10 <property name="use_action_appearance">False</property>
11 <property name="use_underline">True</property>
12 <signal name="clicked" handler="on_button_dist_upgrade_clicked" swapped="no"/>
13@@ -1206,8 +1206,7 @@
14 <property name="label" translatable="yes">Chec_k</property>
15 <property name="visible">True</property>
16 <property name="can_focus">True</property>
17- <property name="can_default">True</property>
18- <property name="receives_default">False</property>
19+ <property name="receives_default">True</property>
20 <property name="image">image-refresh</property>
21 <property name="use_underline">True</property>
22 <property name="use_action_appearance">False</property>
23@@ -1226,7 +1225,7 @@
24 <property name="can_focus">True</property>
25 <property name="can_default">True</property>
26 <property name="has_default">True</property>
27- <property name="receives_default">False</property>
28+ <property name="receives_default">True</property>
29 <property name="image">image-apply</property>
30 <property name="use_underline">True</property>
31 <property name="use_action_appearance">False</property>
32@@ -1410,8 +1409,7 @@
33 <property name="label" translatable="yes">Settings...</property>
34 <property name="visible">True</property>
35 <property name="can_focus">True</property>
36- <property name="can_default">True</property>
37- <property name="receives_default">False</property>
38+ <property name="receives_default">True</property>
39 <property name="use_action_appearance">False</property>
40 <property name="use_underline">True</property>
41 <signal name="clicked" handler="on_button_settings_clicked" swapped="no"/>
42@@ -1437,7 +1435,7 @@
43 <property name="visible">True</property>
44 <property name="can_focus">True</property>
45 <property name="can_default">True</property>
46- <property name="receives_default">False</property>
47+ <property name="receives_default">True</property>
48 <property name="use_action_appearance">False</property>
49 <property name="use_stock">True</property>
50 <accelerator key="Q" signal="clicked" modifiers="GDK_CONTROL_MASK"/>

Subscribers

People subscribed via source and target branches

to status/vote changes: