Merge lp:~evfool/ubuntuone-control-panel/fix715710 into lp:ubuntuone-control-panel

Proposed by Robert Roth
Status: Merged
Approved by: dobey
Approved revision: 65
Merged at revision: 70
Proposed branch: lp:~evfool/ubuntuone-control-panel/fix715710
Merge into: lp:ubuntuone-control-panel
Diff against target: 11 lines (+1/-1)
1 file modified
ubuntuone/controlpanel/gtk/gui.py (+1/-1)
To merge this branch: bzr merge lp:~evfool/ubuntuone-control-panel/fix715710
Reviewer Review Type Date Requested Status
Eric Casteleijn (community) Approve
Natalia Bidart (community) Approve
Review via email: mp+49290@code.launchpad.net

Commit message

- Fixed usage string to be more readable (LP: #715710).

Description of the change

Fixed usage string problem reported in bug #715710.

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Yey!

review: Approve
Revision history for this message
Eric Casteleijn (thisfred) :
review: Approve
Revision history for this message
Eric Casteleijn (thisfred) wrote :

Hi Robert, have you signed the Canonical Contributer's agreement?

review: Needs Information
Revision history for this message
Robert Roth (evfool) wrote :

Hi Eric, you can check that on my launchpad profile page, https://launchpad.net/~evfool, which says : "Signed Ubuntu Code of Conduct: Yes"

Revision history for this message
Eric Casteleijn (thisfred) wrote :

Hi Robert, thanks, but the Code of Conduct and the Contributors Agreement are not the same. The Contributors agreement needs to be signed before contributing to any project that Canonical holds the copyrights to, which is true of all of the Ubuntu One related software.

Thanks for contributing to this project, this is really appreciated, and I apologize for having to be strict about this, even for such a small patch, but the upside is, that you'll only have to sign the agreement once, and it's valid for all the projects covered by it. Do read it carefully though, not everybody agrees with it.

http://www.canonical.com/contributors

Revision history for this message
Robert Roth (evfool) wrote :

> Hi Robert, thanks, but the Code of Conduct and the Contributors Agreement are
> not the same. The Contributors agreement needs to be signed before
> contributing to any project that Canonical holds the copyrights to, which is
> true of all of the Ubuntu One related software.
>

Sorry, I didn't know about the Contributors Agreement and i didn't know this is a project that Canonical holds the copyrights to, as it's not mentioned on that page. Who is the project lead for the ubuntuone-control-panel (who should I send the contributor agreement to, besides contributor-agreement at ......)? Thanks.

Revision history for this message
Eric Casteleijn (thisfred) wrote :

Sorry that that's not clearer on the project page, I'll ask if someone can update that. Please CC John Lenton <email address hidden> when you send in the agreement.

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

John Lenton confirmed that contributor's agreement was signed.

Revision history for this message
Eric Casteleijn (thisfred) :
review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

Attempt to merge into lp:ubuntuone-control-panel failed due to conflicts:

text conflict in ubuntuone/controlpanel/gtk/gui.py

Revision history for this message
Robert Roth (evfool) wrote :

How can a text conflict be fixed?

Revision history for this message
dobey (dobey) wrote :

On Sun, 2011-02-13 at 22:18 +0000, Robert Roth wrote:
> How can a text conflict be fixed?

In your branch, merge trunk back in, fix the conflicts, commit, and
push.

65. By Robert Roth

Conflict resolved

Revision history for this message
Robert Roth (evfool) wrote :

Conflict resolved, it should be ok now. I hope I've done everything fine, this was the first time I've resolved bzr conflicts.

Revision history for this message
dobey (dobey) wrote :

Looks ok.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/controlpanel/gtk/gui.py'
2--- ubuntuone/controlpanel/gtk/gui.py 2011-02-11 20:31:43 +0000
3+++ ubuntuone/controlpanel/gtk/gui.py 2011-02-14 19:45:12 +0000
4@@ -1261,7 +1261,7 @@
5 gobject.TYPE_NONE, ()),
6 }
7
8- QUOTA_LABEL = _('%(used)s used of %(total)s (%(percentage).1f%%)')
9+ QUOTA_LABEL = _('Using %(used)s of %(total)s (%(percentage).1f%%)')
10 DASHBOARD_BUTTON_NAME = 'Account'
11 DEVICES_BUTTON_NAME = 'Devices'
12

Subscribers

People subscribed via source and target branches