Software Properties

Merge lp:~evfool/software-properties/lp1036588 into lp:software-properties

  1. lp1036588
  2. Merge into main
Proposed by Robert Roth
Status: Merged
Merged at revision: 796
Proposed branch: lp:~evfool/software-properties/lp1036588
Merge into: lp:software-properties
Diff against target: 12 lines (+1/-1)
1 file modified
softwareproperties/kde/DialogMirror.py (+1/-1)
To merge this branch: bzr merge lp:~evfool/software-properties/lp1036588
Reviewer Review Type Date Requested Status
Colin Watson Approve
Review via email: mp+123366@code.launchpad.net

Description of the change

Remove unnecessary QString constructor causing the crash, as the interpreter is python3, so QString is undefined, and using native python str should work[1]

[1] http://wiki.python.org/moin/PortingPythonToPy3k/PyQt4

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwareproperties/kde/DialogMirror.py'
2--- softwareproperties/kde/DialogMirror.py 2012-07-05 13:32:44 +0000
3+++ softwareproperties/kde/DialogMirror.py 2012-09-07 21:10:40 +0000
4@@ -233,7 +233,7 @@
5
6 def select_mirror(self, mirror):
7 """Select and expand the path to a matching mirror in the list"""
8- found = self.treeview.findItems(QString(mirror), Qt.MatchExactly|Qt.MatchRecursive)
9+ found = self.treeview.findItems(mirror, Qt.MatchExactly|Qt.MatchRecursive)
10 if found:
11 found[0].setSelected(True)
12 self.treeview.setCurrentItem(found[0])

Subscribers

People subscribed via source and target branches

to status/vote changes: