Merge lp:~evfool/software-center/specs-update into lp:software-center/5.2

Proposed by Robert Roth on 2012-05-17
Status: Merged
Merge reported by: Michael Vogt
Merged at revision: not available
Proposed branch: lp:~evfool/software-center/specs-update
Merge into: lp:software-center/5.2
Diff against target: 58 lines (+14/-14)
1 file modified
softwarecenter/ui/gtk3/views/appdetailsview.py (+14/-14)
To merge this branch: bzr merge lp:~evfool/software-center/specs-update
Reviewer Review Type Date Requested Status
Michael Vogt 2012-05-17 Approve on 2012-05-23
Review via email: mp+106242@code.launchpad.net

Description of the change

This branch contains the following changes (based on the specification https://wiki.ubuntu.com/SoftwareCenter#Software_item_screen) to the application details view
* Moved the recommended applications section after the package details
* Moved the addon status bar after the addons list
* Aligned the star ratings widget vertically with the titles
* Added some vertical padding before the star ratings widget to look better

To post a comment you must log in.
Michael Vogt (mvo) wrote :

Thanks, I merge that into trunk.

review: Approve
Michael Vogt (mvo) wrote :

This is merged into trunk now.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/ui/gtk3/views/appdetailsview.py'
2--- softwarecenter/ui/gtk3/views/appdetailsview.py 2012-05-14 03:16:07 +0000
3+++ softwarecenter/ui/gtk3/views/appdetailsview.py 2012-05-17 19:05:21 +0000
4@@ -1168,9 +1168,9 @@
5 self.review_stats_widget = StarRatingsWidget()
6 self.review_stats = Gtk.HBox()
7 vb_inner.pack_start(
8- self.review_stats, False, False, 0)
9+ self.review_stats, False, False, StockEms.SMALL)
10 self.review_stats.pack_start(
11- self.review_stats_widget, False, False, StockEms.SMALL)
12+ self.review_stats_widget, False, False, 0)
13
14 #~ vb_inner.set_property("can-focus", True)
15 self.title.a11y = vb_inner.get_accessible()
16@@ -1264,23 +1264,12 @@
17 info_vb.pack_start(self.addon_view, False, False, 0)
18
19 self.addons_statusbar = self.addons_manager.status_bar
20- self.addon_view.pack_start(self.addons_statusbar, False, False, 0)
21+ self.addon_view.pack_end(self.addons_statusbar, False, False, 0)
22 self.addon_view.connect('table-built', self._on_addon_table_built)
23
24 self.addons_hbar = self._hbars[1]
25 info_vb.pack_start(self.addons_hbar, False, False, StockEms.SMALL)
26
27- # recommendations
28- catview = CategoriesViewGtk(
29- self.datadir, None, self.cache, self.db, self.icons, None)
30- self.recommended_for_app_panel = RecommendationsPanelDetails(catview)
31- self.recommended_for_app_panel.connect(
32- "application-activated",
33- self._on_recommended_application_activated)
34- self.recommended_for_app_panel.show_all()
35- self.info_vb.pack_start(self.recommended_for_app_panel, False,
36- False, 0)
37-
38 # package info
39 self.info_keys = []
40
41@@ -1309,6 +1298,17 @@
42
43 vb.pack_start(self._hbars[2], False, False, 0)
44
45+ # recommendations
46+ catview = CategoriesViewGtk(
47+ self.datadir, None, self.cache, self.db, self.icons, None)
48+ self.recommended_for_app_panel = RecommendationsPanelDetails(catview)
49+ self.recommended_for_app_panel.connect(
50+ "application-activated",
51+ self._on_recommended_application_activated)
52+ self.recommended_for_app_panel.show_all()
53+ self.info_vb.pack_start(self.recommended_for_app_panel, False,
54+ False, 0)
55+
56 # reviews cascade
57 self.reviews.connect("new-review", self._on_review_new)
58 self.reviews.connect("report-abuse", self._on_review_report_abuse)

Subscribers

People subscribed via source and target branches