Merge lp:~evfool/software-center/smallfixes into lp:software-center

[Robert Roth]

Small fixes to the LinkButton from mkit to behave more like other widgets/links
1) When pressing mouse button over a Linkbutton, dragging out and then back in, the link color turn from normal to active (when pressing the button) and from active to normal (when leaving the link's area) and then back from normal to active (when reentering with the mouse button still pressed) - before this fix it did not, thus when dragging out and in while the button is pressed, the link color did not change back to active, in spite of the fact that the mouse was still over the link, the button was still pressed, and the state was active, but the link was not redrawn as active.
2) When pressing the mouse button over a LinkButton, dragging out from the area of the link, and releasing the button, the clicked signal was always emitted, which is not normal behavior (LP:#796640), when dragging out and releasing the button outside, the link should not be clicked. So emitting the clicked signal only if both pressed and released in the linkbuttons region.

[Gary Lasker (gary-lasker)]

Nice, clean fix, thanks Robert!

review: Approve

=== modified file 'softwarecenter/ui/gtk/widgets/mkit.py'
--- softwarecenter/ui/gtk/widgets/mkit.py	2011-05-19 09:01:54 +0000
+++ softwarecenter/ui/gtk/widgets/mkit.py	2011-06-22 09:07:30 +0000
@@ -1088,9 +1088,10 @@
     def _on_enter(self, cat, event):
         if cat == self._button_press_origin:
             cat.set_state(gtk.STATE_ACTIVE)
+            self._colorise_label_active()
         else:
             cat.set_state(gtk.STATE_PRELIGHT)
-        self._colorise_label_normal()
+            self._colorise_label_normal()
         self.window.set_cursor(self._cursor)
         return
 
@@ -1137,9 +1138,9 @@
         else:
             self._button_press_origin = None
             cat.set_state(gtk.STATE_PRELIGHT)
-        
+            gobject.timeout_add(50, emit_clicked)
+
         self._colorise_label_normal()
-        gobject.timeout_add(50, emit_clicked)
         return
 
     def _on_key_press(self, cat, event):