Merge lp:~evfool/software-center/lp844768 into lp:software-center/5.2

[Robert Roth]

Switch to indeterminate progressbar (as the one shown while purchasing) while transactions are in waiting state (e.g. waiting to close synaptic, or waiting for user input) as requested in bug #844768.

[Michael Vogt (mvo)]

Thanks, this looks great. I changed the "-1", "+1" for the pulse to symbolic constants during the merge
to make it slightly easier to read. But thats just a minor detail :)

review: Approve

=== modified file 'softwarecenter/ui/gtk3/models/pendingstore.py'
--- softwarecenter/ui/gtk3/models/pendingstore.py	2012-03-15 01:32:28 +0000
+++ softwarecenter/ui/gtk3/models/pendingstore.py	2012-05-12 05:33:19 +0000
@@ -127,14 +127,17 @@
         else:
             icon = get_icon_from_theme(self.icons, iconname=iconname,
                 iconsize=self.ICON_SIZE)
+        pulse = -1
+        # if transaction is waiting, switch to indeterminate progress
         if trans.is_waiting():
             status = trans.status_details
+            pulse = 1
         else:
             status = trans.get_status_description()
         status_text = self._render_status_text(appname, status)
         cancel_icon = self._get_cancel_icon(trans.cancellable)
         self.append([trans.tid, icon, appname, status_text,
-            float(trans.progress), -1, cancel_icon])
+            float(trans.progress), pulse, cancel_icon])
 
     def _on_cancellable_changed(self, trans, cancellable):
         #print "_on_allow_cancel: ", trans, allow_cancel
@@ -185,8 +188,10 @@
                 name = row[self.COL_NAME]
                 if trans.is_waiting():
                     st = trans.status_details
+                    row[self.COL_PULSE] = 1
                 else:
                     st = trans.get_status_description(status)
+                    row[self.COL_PULSE] = -1
                 row[self.COL_STATUS] = self._render_status_text(name, st)
 
     def _render_status_text(self, name, status):