Merge lp:~evfool/software-center/lp839389 into lp:software-center

Proposed by Robert Roth
Status: Merged
Merge reported by: Gary Lasker
Merged at revision: not available
Proposed branch: lp:~evfool/software-center/lp839389
Merge into: lp:software-center
Diff against target: 25 lines (+2/-2)
2 files modified
data/ui/gtk3/report_abuse.ui (+1/-1)
data/ui/gtk3/submit_usefulness.ui (+1/-1)
To merge this branch: bzr merge lp:~evfool/software-center/lp839389
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Review via email: mp+105365@code.launchpad.net

Description of the change

Set icon_name instead of icon for all dialogs, fixing bug #839389.

To post a comment you must log in.
Gary Lasker (gary-lasker) wrote :

This displays the correct icon in the *launcher* window, rather than the "not found" icon. Very nice fix, thanks again, Robert!

review: Approve
Gary Lasker (gary-lasker) wrote :

Merged into the lp:software-center/5.2 branch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/ui/gtk3/report_abuse.ui'
2--- data/ui/gtk3/report_abuse.ui 2011-07-05 09:53:26 +0000
3+++ data/ui/gtk3/report_abuse.ui 2012-05-10 17:50:23 +0000
4@@ -9,7 +9,7 @@
5 <property name="window_position">center-on-parent</property>
6 <property name="default_width">400</property>
7 <property name="destroy_with_parent">True</property>
8- <property name="icon">softwarecenter</property>
9+ <property name="icon_name">softwarecenter</property>
10 <child>
11 <object class="GtkVBox" id="dialog-vbox3">
12 <property name="visible">True</property>
13
14=== modified file 'data/ui/gtk3/submit_usefulness.ui'
15--- data/ui/gtk3/submit_usefulness.ui 2011-09-16 09:00:10 +0000
16+++ data/ui/gtk3/submit_usefulness.ui 2012-05-10 17:50:23 +0000
17@@ -8,7 +8,7 @@
18 <property name="border_width">12</property>
19 <property name="window_position">center-on-parent</property>
20 <property name="destroy_with_parent">True</property>
21- <property name="icon">softwarecenter</property>
22+ <property name="icon_name">softwarecenter</property>
23 <child>
24 <object class="GtkVBox" id="dialog-vbox3">
25 <property name="visible">True</property>