Code review comment for lp:~evfool/software-center/lp752376

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks a lot for this branch, its really great to see all your work around software-center!

It looks great there are two small issues:
- the file:// should probably start with file:/ just to ensure that the widest possible range if covered, I think some file managers pass file:/, file:// or even file:///
- the regexp is ideally updated as well for this as the prefix already includes the // so the regexp is not matching exactly what we need here. we can probably simplify it quite a bit and just use "os.path.normpath" after removing the prefix "file:/" to cover prefixed "/".

It would be great if you could have a look, but I'm happy to work on this later today too if you are busy.

« Back to merge proposal