Merge lp:~evfool/software-center/lp1034894 into lp:software-center

Proposed by Robert Roth on 2012-08-29
Status: Merged
Merged at revision: 3136
Proposed branch: lp:~evfool/software-center/lp1034894
Merge into: lp:software-center
Diff against target: 15 lines (+3/-0)
1 file modified
softwarecenter/ui/gtk3/widgets/backforward.py (+3/-0)
To merge this branch: bzr merge lp:~evfool/software-center/lp1034894
Reviewer Review Type Date Requested Status
Michael Vogt 2012-08-29 Approve on 2012-08-30
Review via email: mp+121942@code.launchpad.net

Description of the change

Set the linked style class to the back and forward buttons as requested in bug #1034894.

To post a comment you must log in.
Michael Vogt (mvo) wrote :

Very nice!

review: Approve
Kiwinote (kiwinote) wrote :

Hi! Afaics this branch doesn't actually seem to fix the bug? (If it did it would only fix ltr layouts, not rtl layouts.) I have uploaded http://paste.ubuntu.com/1175521/ which is a drop-in replacement for backforward.py which serves as an example as to how one uses Gtk.STYLE_CLASS_LINKED correctly. The pastebin snippet isn't production ready, so please don't merge as is. Hope that helps.

Michael Vogt (mvo) wrote :

On Thu, Aug 30, 2012 at 10:15:22AM -0000, Kiwinote wrote:
> Hi! Afaics this branch doesn't actually seem to fix the bug? (If it did it would only fix ltr layouts, not rtl layouts.) I have uploaded http://paste.ubuntu.com/1175521/ which is a drop-in replacement for backforward.py which serves as an example as to how one uses Gtk.STYLE_CLASS_LINKED correctly. The pastebin snippet isn't production ready, so please don't merge as is. Hope that helps.

Oh, thanks a lot for noticing that! That sounds like we need to reopen
the bug then.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/ui/gtk3/widgets/backforward.py'
2--- softwarecenter/ui/gtk3/widgets/backforward.py 2012-05-30 18:39:55 +0000
3+++ softwarecenter/ui/gtk3/widgets/backforward.py 2012-08-29 20:47:20 +0000
4@@ -61,8 +61,11 @@
5
6 context = self.left.get_style_context()
7 context.add_class("backforward-left-button")
8+ context.add_class(Gtk.STYLE_CLASS_LINKED)
9+
10 context = self.right.get_style_context()
11 context.add_class("backforward-right-button")
12+ context.add_class(Gtk.STYLE_CLASS_LINKED)
13
14 self.set_button_atk_info_ltr()
15 else: