Merge lp:~evfool/software-center/lp1034894 into lp:software-center

[Robert Roth]

Set the linked style class to the back and forward buttons as requested in bug #1034894.

[Michael Vogt (mvo)]

Very nice!

review: Approve

[Kiwinote (kiwinote)]

Hi! Afaics this branch doesn't actually seem to fix the bug? (If it did it would only fix ltr layouts, not rtl layouts.) I have uploaded http://paste.ubuntu.com/1175521/ which is a drop-in replacement for backforward.py which serves as an example as to how one uses Gtk.STYLE_CLASS_LINKED correctly. The pastebin snippet isn't production ready, so please don't merge as is. Hope that helps.

[Michael Vogt (mvo)]

On Thu, Aug 30, 2012 at 10:15:22AM -0000, Kiwinote wrote:
> Hi! Afaics this branch doesn't actually seem to fix the bug? (If it did it would only fix ltr layouts, not rtl layouts.) I have uploaded http://paste.ubuntu.com/1175521/ which is a drop-in replacement for backforward.py which serves as an example as to how one uses Gtk.STYLE_CLASS_LINKED correctly. The pastebin snippet isn't production ready, so please don't merge as is. Hope that helps.

Oh, thanks a lot for noticing that! That sounds like we need to reopen
the bug then.

=== modified file 'softwarecenter/ui/gtk3/widgets/backforward.py'
--- softwarecenter/ui/gtk3/widgets/backforward.py	2012-05-30 18:39:55 +0000
+++ softwarecenter/ui/gtk3/widgets/backforward.py	2012-08-29 20:47:20 +0000
@@ -61,8 +61,11 @@
 
             context = self.left.get_style_context()
             context.add_class("backforward-left-button")
+            context.add_class(Gtk.STYLE_CLASS_LINKED)
+
             context = self.right.get_style_context()
             context.add_class("backforward-right-button")
+            context.add_class(Gtk.STYLE_CLASS_LINKED)
 
             self.set_button_atk_info_ltr()
         else: