Merge lp:~evfool/software-center/fix889080 into lp:software-center

[Robert Roth]

This branch contains a fix for bug #889080, where in case of commercial applications the app_version is unknown, thus the version comparison between the review_version and app_version has not been executed, but Software-center assumed that the review is "For this version (x)" and "For this version (y)".

To test this, check the reviews for oilrush, where reviews appear with both "For this version (0.81)" and "For this version (0.74)". The fix changes the behavior in this case to show "For version (...)" for all reviews, as we don't know the app version and should not state that the review is for "this" version.

[Michael Vogt (mvo)]

Thanks a lot for working on this!

I merged this with a small tweak, I made the default string "For version %(version)" and only is upstream_version_compare matches change it. Please double check though :)

review: Approve

=== modified file 'softwarecenter/ui/gtk3/widgets/reviews.py'
--- softwarecenter/ui/gtk3/widgets/reviews.py	2011-10-20 16:34:14 +0000
+++ softwarecenter/ui/gtk3/widgets/reviews.py	2011-11-24 06:36:26 +0000
@@ -609,9 +609,10 @@
         #if review version is different to version of app being displayed, 
         # alert user
         version = GObject.markup_escape_text(upstream_version(review_version))
-        if (review_version and
+        if ((review_version and
             app_version and
-            upstream_version_compare(review_version, app_version) != 0):
+            upstream_version_compare(review_version, app_version) != 0)
+            or not app_version):
             version_string = _("For version %(version)s") % { 
                     'version' : version,
                     }