Ubuntu Software Center

Merge lp:~evfool/software-center/fix863233 into lp:software-center

  1. fix863233
  2. Merge into trunk
Proposed by Robert Roth
Status: Merged
Merged at revision: 2481
Proposed branch: lp:~evfool/software-center/fix863233
Merge into: lp:software-center
Diff against target: 12 lines (+2/-1)
1 file modified
softwarecenter/ui/gtk3/widgets/apptreeview.py (+2/-1)
To merge this branch: bzr merge lp:~evfool/software-center/fix863233
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Michael Vogt Pending
Review via email: mp+77947@code.launchpad.net

Description of the change

The branch simply checks for None for a vadjustment retrieved using a method, which in some cases might return None. It fixes bug #863233 without any side-effects.

To post a comment you must log in.
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Looks good, I will merge this now. Thank you, Robert!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/ui/gtk3/widgets/apptreeview.py'
2--- softwarecenter/ui/gtk3/widgets/apptreeview.py 2011-09-21 06:35:20 +0000
3+++ softwarecenter/ui/gtk3/widgets/apptreeview.py 2011-10-03 14:12:29 +0000
4@@ -115,7 +115,8 @@
5
6 def clear_model(self):
7 vadjustment = self.get_scrolled_window_vadjustment()
8- vadjustment.set_value(0)
9+ if vadjustment:
10+ vadjustment.set_value(0)
11 self.expanded_path = None
12 self.appmodel.clear()
13