Merge lp:~evfool/software-center/fix843766 into lp:software-center

Proposed by Robert Roth on 2011-09-07
Status: Merged
Merged at revision: 2270
Proposed branch: lp:~evfool/software-center/fix843766
Merge into: lp:software-center
Diff against target: 12 lines (+1/-1)
1 file modified
softwarecenter/ui/gtk3/models/pendingstore.py (+1/-1)
To merge this branch: bzr merge lp:~evfool/software-center/fix843766
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve on 2011-09-07
Michael Vogt 2011-09-07 Pending
Review via email: mp+74396@code.launchpad.net

Description of the change

Fix simple crash caused by using int 0 instead of float 0 to initialize transaction progress in PendingStore. Fixes bug #843766.

To post a comment you must log in.
Gary Lasker (gary-lasker) wrote :

Looks great, thank you, Robert!

review: Approve
Michael Vogt (mvo) wrote :

Awsome!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/ui/gtk3/models/pendingstore.py'
2--- softwarecenter/ui/gtk3/models/pendingstore.py 2011-07-27 15:53:12 +0000
3+++ softwarecenter/ui/gtk3/models/pendingstore.py 2011-09-07 11:30:26 +0000
4@@ -81,7 +81,7 @@
5 appname = self.backend.pending_purchases[pkgname].appname
6 status_text = self._render_status_text(
7 appname or pkgname, _(u'Installing purchase\u2026'))
8- self.append([pkgname, icon, pkgname, status_text, 0, 1, None])
9+ self.append([pkgname, icon, pkgname, status_text, float(0), 1, None])
10
11 def _pulse_purchase_helper(self):
12 for item in self: