Merge lp:~evfool/software-center/fix739272 into lp:software-center

Proposed by Robert Roth
Status: Merged
Merged at revision: 1746
Proposed branch: lp:~evfool/software-center/fix739272
Merge into: lp:software-center
Diff against target: 81 lines (+14/-14)
2 files modified
softwarecenter/db/application.py (+13/-13)
softwarecenter/version.py (+1/-1)
To merge this branch: bzr merge lp:~evfool/software-center/fix739272
Reviewer Review Type Date Requested Status
software-store-developers Pending
Review via email: mp+57400@code.launchpad.net

This proposal supersedes a proposal from 2011-04-05.

Description of the change

Not found screen capitalization and citation marks fixed (LP: #739272)

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote : Posted in a previous version of this proposal

Thanks for your work on this! Its probably better to use \uXXXX (like \u2026 for …). Otherwise it seems to confuse setup.py build_i18n.

When merging we need to make sure to manually unfuzzy the existing translations for this string. Thats fine (as the string is the same) but if we forget it, the string will not be translated anymore as gettext is not sure its the same or not.

Revision history for this message
Robert Roth (evfool) wrote : Posted in a previous version of this proposal

Updated as requested to use the unicode character codes instead of the characters.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/db/application.py'
2--- softwarecenter/db/application.py 2011-04-12 13:19:00 +0000
3+++ softwarecenter/db/application.py 2011-04-12 21:39:34 +0000
4@@ -210,8 +210,8 @@
5 not debfile_matches and
6 not channel_matches and
7 not section_matches):
8- self._error = _("Not Found")
9- self._error_not_found = _("There isn't a software package called \"%s\" in your current software sources.") % self.pkgname.capitalize()
10+ self._error = _("Not found")
11+ self._error_not_found = _(u"There isn\u2019t a software package called \u201c%s\u201D in your current software sources.") % self.pkgname
12
13 def same_app(self, other):
14 return self.pkgname == other.pkgname
15@@ -310,8 +310,8 @@
16 return self._error
17 # this may have changed since we inited the appdetails
18 elif self.pkg_state == PKG_STATE_NOT_FOUND:
19- self._error = _("Not Found")
20- self._error_not_found = _("There isn't a software package called \"%s\" in your current software sources.") % self.pkgname.capitalize()
21+ self._error = _("Not found")
22+ self._error_not_found = _(u"There isn\u2019t a software package called \u201c%s\u201D in your current software sources.") % self.pkgname
23 return self._error_not_found
24
25 @property
26@@ -441,8 +441,8 @@
27 if self._unavailable_channel():
28 return PKG_STATE_NEEDS_SOURCE
29 else:
30- self._error = _("Not Found")
31- self._error_not_found = _("There isn't a software package called \"%s\" in your current software sources.") % self.pkgname.capitalize()
32+ self._error = _("Not found")
33+ self._error_not_found = _(u"There isn\u2019t a software package called \u201c%s\u201D in your current software sources.") % self.pkgname
34 return PKG_STATE_NOT_FOUND
35 else:
36 if self.price:
37@@ -455,8 +455,8 @@
38 for component in components:
39 if component and self._unavailable_component(component_to_check=component):
40 return PKG_STATE_NEEDS_SOURCE
41- self._error = _("Not Found")
42- self._error_not_found = _("There isn't a software package called \"%s\" in your current software sources.") % self.pkgname.capitalize()
43+ self._error = _("Not found")
44+ self._error_not_found = _(u"There isn\u2019t a software package called \u201c%s\u201D in your current software sources.") % self.pkgname
45 return PKG_STATE_NOT_FOUND
46 return PKG_STATE_UNKNOWN
47
48@@ -621,17 +621,17 @@
49 self._deb = None
50 self._pkg = None
51 if not os.path.exists(self._app.request):
52- self._error = _("Not Found")
53- self._error_not_found = _("The file \"%s\" does not exist.") % self._app.request
54+ self._error = _("Not found")
55+ self._error_not_found = _(u"The file \u201c%s\u201d does not exist.") % self._app.request
56 else:
57 mimetype = guess_type(self._app.request)
58 if mimetype[0] != "application/x-debian-package":
59- self._error = _("Not Found")
60- self._error_not_found = _("The file \"%s\" is not a software package.") % self._app.request
61+ self._error = _("Not found")
62+ self._error_not_found = _(u"The file \u201c%s\u201d is not a software package.") % self._app.request
63 else:
64 # hm, deb files from launchpad get this error..
65 self._error = _("Internal Error")
66- self._error_not_found = _("The file \"%s\" could not be opened.") % self._app.request
67+ self._error_not_found = _(u"The file \u201c%s\u201d could not be opened.") % self._app.request
68 return
69
70 if self.pkgname and self.pkgname != self._app.pkgname:
71
72=== modified file 'softwarecenter/version.py'
73--- softwarecenter/version.py 2011-03-31 14:05:16 +0000
74+++ softwarecenter/version.py 2011-04-12 21:39:34 +0000
75@@ -1,5 +1,5 @@
76
77-VERSION='3.1.25'
78+VERSION='3.1.25.1'
79 CODENAME='UNRELEASED'
80 DISTRO='Ubuntu'
81 RELEASE='11.04'