Merge lp:~evfool/scratch/lp1173737 into lp:~elementary-apps/scratch/scratch

Proposed by Robert Roth
Status: Merged
Approved by: Cody Garver
Approved revision: 1307
Merged at revision: 1313
Proposed branch: lp:~evfool/scratch/lp1173737
Merge into: lp:~elementary-apps/scratch/scratch
Diff against target: 31 lines (+5/-3)
1 file modified
src/MainWindow.vala (+5/-3)
To merge this branch: bzr merge lp:~evfool/scratch/lp1173737
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+222099@code.launchpad.net

Commit message

Move the findbar above the splitview instead of spanning the whole window (lp:1173737)

Description of the change

Moved the findbar to be shown only above the split view, as it doesn't have anything to do with the file browser/source browser (fix lp:1173737).

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/MainWindow.vala'
2--- src/MainWindow.vala 2014-05-20 10:58:53 +0000
3+++ src/MainWindow.vala 2014-06-04 20:20:27 +0000
4@@ -211,7 +211,10 @@
5 hp2 = new Granite.Widgets.ThinPaned ();
6 vp = new Granite.Widgets.ThinPaned ();
7 vp.orientation = Orientation.VERTICAL;
8-
9+
10+ var content = new Gtk.Box (Orientation.VERTICAL, 0);
11+ content.pack_start (search_revealer, false, true, 0);
12+ content.pack_start (split_view, true, true, 0);
13 // Set a proper position for ThinPaned widgets
14 int width, height;
15 this.get_size (out width, out height);
16@@ -221,14 +224,13 @@
17 vp.position = (height - 150);
18
19 hp1.pack1 (sidebar, false, false);
20- hp1.pack2 (split_view, true, false);
21+ hp1.pack2 (content, true, false);
22 hp2.pack1 (hp1, true, false);
23 hp2.pack2 (contextbar, false, false);
24 vp.pack1 (hp2, true, false);
25 vp.pack2 (bottombar, false, false);
26
27 // Add everything to the window
28- main_box.pack_start (search_revealer, false, true, 0);
29 main_box.pack_start (loading_view, true, true, 0);
30 main_box.pack_start (vp, false, true, 0);
31 this.add (main_box);

Subscribers

People subscribed via source and target branches