Merge lp:~evfool/jockey/stringfixes into lp:jockey

Proposed by Robert Roth
Status: Merged
Merged at revision: 741
Proposed branch: lp:~evfool/jockey/stringfixes
Merge into: lp:jockey
Diff against target: 52 lines (+5/-5)
2 files modified
backend/com.ubuntu.devicedriver.policy.in (+4/-4)
examples/handlers/vmware-client.py (+1/-1)
To merge this branch: bzr merge lp:~evfool/jockey/stringfixes
Reviewer Review Type Date Requested Status
Martin Pitt (community) Approve
Review via email: mp+73737@code.launchpad.net

Description of the change

Fixes two string-fix bugs, one in the VMWare description string caused by missing a space from both the end of the line and the beginning of the next line in the source (bug #722936), and another one related to the authentication required strings presented, made them more user-friendly, similar to the ones in software-center/aptdaemon, as suggested in bug #799725.

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks Robert! This looks good, and I already merged the "toolsfor" change into trunk. The other change requires an UIF first, I asked in https://bugs.launchpad.net/hundredpapercuts/+bug/799725/comments/3

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'backend/com.ubuntu.devicedriver.policy.in'
2--- backend/com.ubuntu.devicedriver.policy.in 2009-07-13 15:43:16 +0000
3+++ backend/com.ubuntu.devicedriver.policy.in 2011-09-02 00:06:29 +0000
4@@ -16,7 +16,7 @@
5
6 <action id="com.ubuntu.devicedriver.info">
7 <_description>Get information about local device drivers</_description>
8- <_message>System policy prevents querying device drivers</_message>
9+ <_message>To query the device drivers, you need to authenticate.</_message>
10 <defaults>
11 <allow_any>yes</allow_any>
12 <allow_inactive>yes</allow_inactive>
13@@ -26,7 +26,7 @@
14
15 <action id="com.ubuntu.devicedriver.check">
16 <_description>Check for newly available drivers for, and used drivers on this system</_description>
17- <_message>System policy prevents checking driver status</_message>
18+ <_message>To check the driver status, you need to authenticate.</_message>
19 <defaults>
20 <allow_inactive>yes</allow_inactive>
21 <allow_active>yes</allow_active>
22@@ -35,7 +35,7 @@
23
24 <action id="com.ubuntu.devicedriver.update">
25 <_description>Query local and remote driver databases for updated drivers for the system</_description>
26- <_message>System policy prevents querying driver databases for updates</_message>
27+ <_message>To query the driver databases for updates, you need to authenticate.</_message>
28 <defaults>
29 <allow_inactive>yes</allow_inactive>
30 <allow_active>yes</allow_active>
31@@ -44,7 +44,7 @@
32
33 <action id="com.ubuntu.devicedriver.install">
34 <_description>Install or remove device drivers</_description>
35- <_message>System policy prevents installation/removal of device drivers</_message>
36+ <_message>To install or remove device drivers, you need to authenticate.</_message>
37 <defaults>
38 <allow_any>auth_admin</allow_any>
39 <allow_inactive>auth_admin</allow_inactive>
40
41=== modified file 'examples/handlers/vmware-client.py'
42--- examples/handlers/vmware-client.py 2011-02-14 09:20:53 +0000
43+++ examples/handlers/vmware-client.py 2011-09-02 00:06:29 +0000
44@@ -17,7 +17,7 @@
45 name=_('VMWare Client Tools'),
46 description=_('Install VMWare client drivers and tools'),
47 rationale=_('Install the VMWare client drivers and tools'
48- 'for your VMWare based Ubuntu installation.\n\n'
49+ ' for your VMWare based Ubuntu installation.\n\n'
50 'This should help you use Ubuntu in your VM.'))
51 self.package = 'open-vm-dkms'
52 self._free = True

Subscribers

People subscribed via source and target branches

to status/vote changes: