lp:evergreen/3.4

Created by Dan Wells on 2019-10-25 and last modified on 2020-04-01
Get this branch:
bzr branch lp:evergreen/3.4

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Evergreen Bug Wranglers
Project:
Evergreen
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://git.evergreen-ils.org/Evergreen.git,branch=rel_3_4.

The next import is scheduled to run in 4 hours.

Last successful import was 1 hour ago.

Import started 1 hour ago on izar and finished 1 hour ago taking 30 seconds — see the log
Import started 7 hours ago on alnitak and finished 7 hours ago taking 30 seconds — see the log
Import started 13 hours ago on izar and finished 13 hours ago taking 25 seconds — see the log
Import started 19 hours ago on izar and finished 19 hours ago taking 40 seconds — see the log
Import started on 2020-04-05 on alnitak and finished on 2020-04-05 taking 30 seconds — see the log
Import started on 2020-04-05 on izar and finished on 2020-04-05 taking 30 seconds — see the log
Import started on 2020-04-04 on alnitak and finished on 2020-04-04 taking 30 seconds — see the log
Import started on 2020-04-04 on izar and finished on 2020-04-04 taking 30 seconds — see the log
Import started on 2020-04-04 on alnitak and finished on 2020-04-04 taking 30 seconds — see the log
Import started on 2020-04-04 on izar and finished on 2020-04-04 taking 25 seconds — see the log

Recent revisions

23821. By Jason Boyer on 2020-04-01

LP1774268: Tidy up hold notification testing

Signed-off-by: Jason Boyer <email address hidden>

23820. By Jeff Davis on 2020-04-01

LP#1774268: handle opac.hold_notify empty string in AngJS patron editor

If a patron does not want either phone or email hold notifications,
their opac.hold_notify user setting will be an empty string. Let's
ensure that the hold notify checkboxes remain unchecked in the patron
editor when that is the case.

Signed-off-by: Jeff Davis <email address hidden>
Signed-off-by: Michele Morgan <email address hidden>
Signed-off-by: Jason Boyer <email address hidden>

23819. By Suzanne Paterno on 2020-04-01

LP 1774268
On patron edit screen set the email and phone notification to true when patron doesn't have any prefernces. This mimics the behavior in the xul client.

Signed-off-by: Michele Morgan <email address hidden>
Signed-off-by: Jason Boyer <email address hidden>

23818. By Jason Etheridge on 2020-03-25

lp1834251: I18Nize these alt tags

Signed-off-by: Jason Etheridge <email address hidden>
Signed-off-by: Jane Sandberg <email address hidden>

23817. By Sam Link <slink@LIBPC002> on 2020-03-20

Bug 1834251: adding alt attributes to Open-ILS\src\templates\kpac\parts\paginate.tt2.

Signed-off-by: Sam Link <slink@LIBPC002>
Signed-off-by: Llewellyn Marshall <email address hidden>
Signed-off-by: Jane Sandberg <email address hidden>

23816. By Sam Link on 2020-03-05

LP1865951: Fixes to consistency in two files, creating uniform capitalization and use of ellipses

Signed-off-by: Sam Link <email address hidden>
Signed-off-by: Jane Sandberg <email address hidden>

23815. By Bill Erickson on 2020-02-28

LP1860460 3.4 Angular version mismatch repairs

Angular v7, used in 3.4, does not support the {static:boolean} option
for @ViewChild. Remove some instances that were back-ported.

Signed-off-by: Bill Erickson <email address hidden>

23814. By Mike Risher on 2020-02-27

lp1789491 visited link color

Some interfaces use a red or dark red background color for certain rows
and the visited link color makes it hard to read. Adjust this color
so there is more contrast against the red background.

Signed-off-by: Mike Risher <email address hidden>
Signed-off-by: Jessica Woolford <email address hidden>
Signed-off-by: Jane Sandberg <email address hidden>

23813. By Chris Sharp on 2020-02-26

LP#1863929 - Fix sample survey data.

Since we enter the surveys, questions, and answers with specified ID values
but don't set the values to one higher, testers were unable to enter survey
data.

Signed-off-by: Chris Sharp <email address hidden>
Signed-off-by: Bill Erickson <email address hidden>

23812. By Josh Stompro <email address hidden> on 2020-02-25

LP#850160 - Event Def Environment Fleshing Might Have Issue

When the action trigger environment gets fleshed out, there is a bug
with how might_have relations are fleshed ever other time they are
evaluated.

The first time they are correctly evaluated, but then the next time the
same path gets evaluated, the object gets reset to the first value in
the object.

See https://bugs.launchpad.net/evergreen/+bug/850160 for testing notes.

The fix is to add an extra check to only grab the first element if the object is
an array. If it isn't an array it means it has already been fleshed.

Testing notes:

One way to test this bug is by looking at the self check
receipt, hours of operations bug.
https://bugs.launchpad.net/evergreen/+bug/793627

By default, the self check receipt will fail for even numbers of items checked
out because the hours of operation doesn't get fleshed correctly.

With this change, the receipt should print for even and odd numbers of items.

Another test is to add user.money_summary to a lost/bill action trigger
event notification. Before the fix, if you have an even number of items billec, the
user.money_summary gets set to the first object in that table, and for odd
numbers of items, user.money_summary.balanced_owed gets set correctly.

Signed-off-by: Josh Stompro <email address hidden>
Signed-off-by: Mike Rylander <email address hidden>

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.