Merge lp:~evarlast/software-properties/support-update into lp:software-properties

[Jay R. Wren]

Add the -u, --update option to add-apt-repository to automatically update the apt cache.

By using apt.cache.Cache().update(sources_list=) only the newly added source is downloaded. The update method automatically sets and resets options so that other sources are not removed. This is similar to running this command:

apt-get update -o Dir::Etc::sourcelist="sources.list.d/${source}" \
        -o Dir::Etc::sourceparts="-" -o APT::Get::List-Cleanup="0"

The benefit is that using -u is faster (potentially MUCH faster) than downloading and building package cache for all sources.

[Michael Vogt (mvo)]

I like that, thanks a lot!

review: Approve

=== modified file 'add-apt-repository'
--- add-apt-repository	2014-09-24 09:50:37 +0000
+++ add-apt-repository	2015-05-30 03:03:01 +0000
@@ -69,6 +69,9 @@
     parser.add_option("-y", "--yes", action="store_true",
         dest="assume_yes", default=False,
         help=_("Assume yes to all queries"))
+    parser.add_option("-u", "--update", action="store_true",
+        dest="update", default=False,
+        help=_("Update package cache after adding"))
     (options, args) = parser.parse_args()
 
     if os.geteuid() != 0:
@@ -168,5 +171,5 @@
         except ShortcutException as e:
             print(e)
             sys.exit(1)
-        
+
         sp.sourceslist.save()

=== modified file 'softwareproperties/SoftwareProperties.py'
--- softwareproperties/SoftwareProperties.py	2014-12-01 07:05:24 +0000
+++ softwareproperties/SoftwareProperties.py	2015-05-30 03:03:01 +0000
@@ -753,6 +753,10 @@
     if worker:
         # wait for GPG key to be downloaded
         worker.join(30)
+    if self.options.update:
+        import apt
+        cache = apt.Cache()
+        cache.update(sources_list=new_debsrc_entry.file)
     return True
 
   def remove_source(self, source, remove_source_code=True):