Merge lp:~evarlast/charms/trusty/mongodb/trunk into lp:charms/trusty/mongodb

Proposed by Jay R. Wren
Status: Merged
Merged at revision: 58
Proposed branch: lp:~evarlast/charms/trusty/mongodb/trunk
Merge into: lp:charms/trusty/mongodb
Diff against target: 13 lines (+2/-1)
1 file modified
hooks/hooks.py (+2/-1)
To merge this branch: bzr merge lp:~evarlast/charms/trusty/mongodb/trunk
Reviewer Review Type Date Requested Status
Charles Butler (community) Approve
Review via email: mp+242136@code.launchpad.net

Description of the change

Don't install unneeded dev packages on deploy.

mongodb package Recommends: mongodb-dev. This Requires a c++ compiler and boost dev packages, none of which are needed by the charm.

This change speeds up deploy of this charm significantly.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_amulet_test #465 trusty-mongodb for evarlast mp242136
    AMULET FAIL: amulet-test missing

AMULET Results (max last 5 lines):
INFO:root:Workspace dir: /var/lib/jenkins/workspace/charm_amulet_test
INFO:root:Reading file: Makefile
INFO:root:Searching for: ['@juju test']
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/9079700/
Build: http://10.98.191.181:8080/job/charm_amulet_test/465/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_unit_test #957 trusty-mongodb for evarlast mp242136
    UNIT OK: passed

UNIT Results (max last 5 lines):
INFO:root:command: make -f Makefile unittest
  tests/10-unit.test
  test_success (test_write_log_rotate_config.TestWriteLogrotateConfigFile) ... ok
  Ran 1 test in 0.005s
  OK

Full unit test output: http://paste.ubuntu.com/9079706/
Build: http://10.98.191.181:8080/job/charm_unit_test/957/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_lint_check #1123 trusty-mongodb for evarlast mp242136
    LINT FAIL: lint-test missing

LINT Results (max last 5 lines):
INFO:root:Workspace dir: /var/lib/jenkins/workspace/charm_lint_check
INFO:root:Reading file: Makefile
INFO:root:Searching for: ['@flake8']
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full lint test output: http://paste.ubuntu.com/9079709/
Build: http://10.98.191.181:8080/job/charm_lint_check/1123/

Revision history for this message
Charles Butler (lazypower) wrote :

+1 LGTM

Thanks for the contribution jrwren

review: Approve
58. By Charles Butler

[r=lazypower] <email address hidden> 2014-11-18 prevent unneeded package install

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/hooks.py'
2--- hooks/hooks.py 2014-11-03 20:03:24 +0000
3+++ hooks/hooks.py 2014-11-18 21:39:20 +0000
4@@ -727,7 +727,8 @@
5 juju_log("Installing mongodb")
6 add_source(config('source'), config('key'))
7 apt_update(fatal=True)
8- apt_install(packages=['mongodb', 'python-yaml'], fatal=True)
9+ apt_install(packages=['mongodb-server', 'mongodb-clients', 'python-yaml'],
10+ fatal=True)
11
12
13 @hooks.hook('config-changed')

Subscribers

People subscribed via source and target branches